do not prefer substs relate during coherence #111987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
lcnr
force-pushed
the
alias-relate-coherence
branch
from
94b1506
to
e7fa993
Compare
bors
added
S-waiting-on-bors
BoxyUwU
reviewed
May 26, 2023
| // | ||
| // As this is incomplete, we must not do so during coherence. | ||
| match (self.solver_mode(), subst_relate_response) { | ||
| (SolverMode::Normal, Ok(response)) => Ok(response), |
There was a problem hiding this comment.
I think its unfortunate that this means that improving try_merge_responses to not require floundering as much can break code because it could cause us to not take this path, and subst_relate_response can have a stronger response than the merged one :(
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
May 26, 2023
…yUwU do not prefer substs relate during coherence r? `@compiler-errors`
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
May 26, 2023
…yUwU do not prefer substs relate during coherence r? ``@compiler-errors``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 26, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#111714 (Stop confusing specification levels when computing expectations.) - rust-lang#111927 (Migrate `item_static` to Askama) - rust-lang#111954 (improve error message for calling a method on a raw pointer with an unknown pointee) - rust-lang#111973 (Update current implementation comments for `select_nth_unstable`) - rust-lang#111976 (Generate docs for bootstrap itself) - rust-lang#111977 (Make errors from `x doc` less verbose) - rust-lang#111987 (do not prefer substs relate during coherence) - rust-lang#111991 (Change ty and const error's pretty printing to be in braces) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @compiler-errors