-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DesugaringKind::Replace. #111952
Remove DesugaringKind::Replace. #111952
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri This PR changes Stable MIR This PR changes MIR cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look good to me. r=me with .stderr
mystery resolved I guess
} | ||
|
||
fn test_args(b: Box<i32>) { //~ HELP consider making this binding mutable | ||
//~| SUGGESTION mut b | ||
b = Box::new(2); //~ ERROR cannot assign to immutable argument `b` | ||
//~| NOTE cannot assign to immutable argument | ||
//~| NOTE in this expansion of desugaring of drop and replace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why aren't those notes in the .stderr
file? Like... I understand why they should not be there anymore but the diff of .stderr
doesn't contain them at all?...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This happens with all the macro backtrace "in this expansion" messages. This is probably deliberate, but I can't track where in code this comes from.
@bors r=WaffleLapkin |
Remove DesugaringKind::Replace. A simple boolean flag is enough.
…llaumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#111936 (Include test suite metadata in the build metrics) - rust-lang#111952 (Remove DesugaringKind::Replace.) - rust-lang#111966 (Add #[inline] to array TryFrom impls) - rust-lang#111983 (Perform MIR type ops locally in new solver) - rust-lang#111997 (Fix re-export of doc hidden macro not showing up) - rust-lang#112014 (rustdoc: get unnormalized link destination for suggestions) r? `@ghost` `@rustbot` modify labels: rollup
Remove DesugaringKind::Replace. A simple boolean flag is enough.
A simple boolean flag is enough.