Rollup of 8 pull requests #108821

matthiaskrgr · 2023-03-06T15:42:02Z

Successful merges:

const_eval: implies_by in rustc_const_unstable #107801 (const_eval: implies_by in rustc_const_unstable)
Fix ObligationCtxt::sub #108750 (Fix ObligationCtxt::sub)
Add regression tests for issue 70919 #108780 (Add regression tests for issue 70919)
Check for free regions in MIR validation #108786 (Check for free regions in MIR validation)
Do not ICE when interpreting a cast between non-monomorphic types #108790 (Do not ICE when interpreting a cast between non-monomorphic types)
Do not ICE when failing to normalize in ConstProp. #108803 (Do not ICE when failing to normalize in ConstProp.)
Emit the suspicious_auto_trait_impls for negative impls as well #108807 (Emit the suspicious_auto_trait_impls for negative impls as well)
Add regression test for #98444 #108812 (Add regression test for Taking a shared reference of an array suppresses the unconditional_panic lint #98444)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Extend support for `implies_by` (from `#[stable]` and `#[unstable]`) to `#[rustc_const_stable]` and `#[rustc_const_unstable]`. Signed-off-by: David Wood <[email protected]>

Desugaring DropAndReplace at MIR build (rust-lang#107844) fixed issue 70919. Add regressions tests, borrowed from rust-lang#102078, to ensure we check for this in the future. Co-authored-by: Aaron Hill <[email protected]>

… r=Nilstrieb const_eval: `implies_by` in `rustc_const_unstable` Fixes rust-lang#107605. Extend support for `implies_by` (from `#[stable]` and `#[unstable]`) to `#[rustc_const_stable]` and `#[rustc_const_unstable]`. cc ``@steffahn``

Fix `ObligationCtxt::sub` typo it seems

Add regression tests for issue 70919 Desugaring DropAndReplace at MIR build (rust-lang#107844) fixed rust-lang#70919. Add regressions tests, borrowed from rust-lang#102078, to ensure we check for this in the future. cc ``@Aaron1011``

…-obk Check for free regions in MIR validation This turns rust-lang#108720 into a MIR validation failure that will reproduce without debug-assertions enabled. ``` error: internal compiler error: broken MIR in Item(WithOptConstParam { did: DefId(0:296 ~ futures_util[3805]::future::future::remote_handle::{impl#3}::poll), const_param_did: None }) (after pass ScalarReplacementOfAggregates) at bb0[0]: Free regions in optimized runtime-post-cleanup MIR --> /home/ben/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-util-0.3.26/src/future/future/remote_handle.rs:96:13 | 96 | let this = self.project(); | ^^^^ ```

Do not ICE when interpreting a cast between non-monomorphic types Fixes rust-lang#101596

…li-obk Do not ICE when failing to normalize in ConstProp. There is no reason to delay a bug there, as we bubble up the failure as TooGeneric. Fixes rust-lang#97728

…t_impls, r=lcnr Emit the suspicious_auto_trait_impls for negative impls as well Fixes rust-lang#108804

…rieb Add regression test for rust-lang#98444 cc rust-lang#108730 this will need to be changed to a `check-fail` test once it lands. Fixes rust-lang#98444

matthiaskrgr · 2023-03-06T15:42:17Z

@bors r+ rollup=never p=8

bors · 2023-03-06T15:42:20Z

📌 Commit 567cab9 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2023-03-06T22:15:58Z

⌛ Testing commit 567cab9 with merge 81be7b8...

bors · 2023-03-07T01:17:31Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 81be7b8 to master...

bors · 2023-03-07T01:17:31Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 81be7b8 to master...

rust-timer · 2023-03-07T01:17:37Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha

previous master: 81be7b86d3

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-03-07T01:17:38Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha

previous master: 81be7b86d3

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-03-07T01:19:48Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#108812	6c8d1817f19ea9bb92ec786d1790e1cce8f3023c
#108807	a2789f7b5e04fe8f088a4ef0dded3eb409d9bcf4
#108803	2966021d65d931810b0d878d7703bf7e9e10794f
#108790	a54bdf627c97763162bce9430dd3d8ee76ddab1f
#108786	d15b9e694aaf3835dcfa5977352a888a697188b6
#108780	6443895f9bcbd3705dedf950bfad45bfe4664f7b
#108750	404a85f2a9adef2658fa92e0c44ea7c3342892c5
#107801	69db1ef059ae445507279ac14e66c8e4faed5f5a

previous master: f63ccaf25f

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-03-07T03:12:53Z

Finished benchmarking commit (81be7b8): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	3
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.8%	[-2.8%, -2.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.8%	[-2.8%, -2.8%]	1

davidtwco and others added 20 commits February 8, 2023 15:09

const_eval: implies_by in rustc_const_unstable

9127834

Extend support for `implies_by` (from `#[stable]` and `#[unstable]`) to `#[rustc_const_stable]` and `#[rustc_const_unstable]`. Signed-off-by: David Wood <[email protected]>

sub is not sup

1f92c61

Add regression tests for issue 70919

beebd3a

Desugaring DropAndReplace at MIR build (rust-lang#107844) fixed issue 70919. Add regressions tests, borrowed from rust-lang#102078, to ensure we check for this in the future. Co-authored-by: Aaron Hill <[email protected]>

Check for free regions in MIR validation

cb4ebc1

Add test.

5d7234a

Do not ICE when casting polymorphic values.

858eab6

Do not ICE when failing to normalize in ConstProp.

8c0cbd8

emit the suspicious_auto_trait_impls for negative impls as well

2fe288f

Moves the negative impls into a separate test file

5c0f55d

Bless the remaining ui tests

23ba4ce

Bless the suspicious-negative-impls-lint.rs

717f93c

Add regression test for 98444

33d7fad

Rollup merge of rust-lang#108750 - compiler-errors:aaaaaaaa, r=lcnr

6240b54

Fix `ObligationCtxt::sub` typo it seems

Rollup merge of rust-lang#108790 - cjgillot:mono-cast, r=oli-obk

3ae047b

Do not ICE when interpreting a cast between non-monomorphic types Fixes rust-lang#101596

Rollup merge of rust-lang#108803 - cjgillot:const-prop-normalize, r=o…

ab7dd09

…li-obk Do not ICE when failing to normalize in ConstProp. There is no reason to delay a bug there, as we bubble up the failure as TooGeneric. Fixes rust-lang#97728

Rollup merge of rust-lang#108807 - MU001999:lint/suspicious_auto_trai…

3279f7e

…t_impls, r=lcnr Emit the suspicious_auto_trait_impls for negative impls as well Fixes rust-lang#108804

Rollup merge of rust-lang#108812 - albertlarsan68:test-98444, r=Nilst…

567cab9

…rieb Add regression test for rust-lang#98444 cc rust-lang#108730 this will need to be changed to a `check-fail` test once it lands. Fixes rust-lang#98444

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Mar 6, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2023

bors added merged-by-bors This PR was explicitly merged by bors. labels Mar 7, 2023

bors merged commit 81be7b8 into rust-lang:master Mar 7, 2023

rustbot added this to the 1.70.0 milestone Mar 7, 2023

Alexendoo mentioned this pull request Mar 8, 2023

[ICE] Const generics + Const normalization + Specialization #72845

Closed

lukas-code mentioned this pull request Apr 3, 2023

regression: ICE failing to normalize #109743

Closed

matthiaskrgr deleted the rollup-cmkbgpr branch March 16, 2024 18:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 8 pull requests #108821

Rollup of 8 pull requests #108821

matthiaskrgr commented Mar 6, 2023

matthiaskrgr commented Mar 6, 2023

bors commented Mar 6, 2023

bors commented Mar 6, 2023

bors commented Mar 7, 2023

bors commented Mar 7, 2023

rust-timer commented Mar 7, 2023

rust-timer commented Mar 7, 2023

rust-timer commented Mar 7, 2023

rust-timer commented Mar 7, 2023

Rollup of 8 pull requests #108821

Rollup of 8 pull requests #108821

Conversation

matthiaskrgr commented Mar 6, 2023

matthiaskrgr commented Mar 6, 2023

bors commented Mar 6, 2023

bors commented Mar 6, 2023

bors commented Mar 7, 2023

bors commented Mar 7, 2023

rust-timer commented Mar 7, 2023

rust-timer commented Mar 7, 2023

rust-timer commented Mar 7, 2023

rust-timer commented Mar 7, 2023

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles