-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 9 pull requests #108521
Rollup of 9 pull requests #108521
Conversation
add scfix test I'm not sure if we currently *guarantee* to pass this test, but at least I was unable to get it to fail. Cc `@cbeuw`
It was broken, and the fixed version actually fails...
remove scfix test It was broken, and the fixed version actually fails... Thanks `@cbeuw` !
Co-authored-by: Ralf Jung <[email protected]>
Explain how to make josh authenticate with github via ssh Without this I was unable to push, even though pushing directly to https without josh works.
…ecializable-rpitits, r=lcnr Don't project specializable RPITIT projection This effective rejects specialization + RPITIT/AFIT (usages of `impl Trait` in traits) because the implementation is significantly complicated over making regular "default" trait method bodies work. I have another PR that experimentally fixes all this, but the code may not be worth investing in.
…, r=compiler-errors Unify validity checks into a single query Previously, there were two queries to check whether a type allows the 0x01 or zeroed bitpattern. I am planning on adding a further initness to check in rust-lang#100423, truly uninit for MaybeUninit, which would make this three queries. This seems overkill for such a small feature, so this PR unifies them into one. I am not entirely happy with the naming and key type and open for improvements. r? oli-obk
…lbertlarsan68 bootstrap: Update the output of the `check` descriptions This should bring the output from `x check` in line with the changes in rust-lang#108171
…r=compiler-errors Make `match` arm comma suggestion more clear Fixes rust-lang#108472
Merge diagnostic_items duplicate diagnostics To deduplicate how we diagnose duplication.
…ddle Clean up JS files code a bit I mostly moved values closer to where they are used to make the code reading easier. r? ```@notriddle```
update Miri r? ``@ghost``
…mpiler-errors Don't trigger error for ReError when other region is empty. Fixes [rust-lang#107988](rust-lang#107988)
Remove @nagisa from review rotation I have been reviewing PRs for a long while during weekends, however recently I’ve been having trouble commiting to that as well. Every weekend I’ve been spending working on a house. I may return myself to the rotation in a couple of months. I may also just start ninja'ing up some PRs from the PR list whenever I find some time for reviews again, without putting myself back into the rotation, in acknowledgement that me being able to review every weekend or every second weekend is not a great experience for the contributors waiting on reviews from me.
@bors r+ rollup=never p=9 |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR: previous master: 58136ffa92 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (49b9cc5): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
Successful merges:
check
descriptions #108463 (bootstrap: Update the output of thecheck
descriptions)match
arm comma suggestion more clear #108477 (Makematch
arm comma suggestion more clear)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup