remove unstable pick_stable_methods_before_any_unstable flag
#108285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
nbdd0121
approved these changes
Feb 20, 2023
This comment has been minimized.
This comment has been minimized.
BoxyUwU
force-pushed
the
remove_pick_stable_before_unstable_flag
branch
from
f0c2fea
to
4f2001a
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 21, 2023
Rollup of 7 pull requests Successful merges: - rust-lang#108000 (lint: don't suggest MaybeUninit::assume_init for uninhabited types) - rust-lang#108105 (Explain the default panic hook better) - rust-lang#108141 (Add rpitit queries) - rust-lang#108272 (docs: wrong naming convention in struct keyword doc) - rust-lang#108285 (remove unstable `pick_stable_methods_before_any_unstable` flag) - rust-lang#108289 (Name placeholder in some region errors) - rust-lang#108290 (Add a test for default trait method with RPITITs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag was only added in #90329 in case there was any issue with the impl so that it would be easy to tell nightly users to use the flag to disable the new logic to fix their code. It's now been enabled for two years and also I can't find any issues corresponding to this new functionality? This flag made it way harder to understand how this code works so it would be nice to remove it and simplify what's going on.
cc @nbdd0121
r? @oli-obk