Rollup of 6 pull requests #108159

matthiaskrgr · 2023-02-17T11:39:08Z

Successful merges:

Default repr(C) enums to c_int size #107592 (Default repr(C) enums to c_int size)
Copy bin/* and lib/*.dylib files to stage0-sysroot #107956 (Copy bin/* and lib/*.dylib files to stage0-sysroot)
fix a line, and do a consistency fix #108126 (fix a line, and do a consistency fix)
Add compiler-errors to a few more triagebot groups #108144 (Add compiler-errors to a few more triagebot groups)
typo #108149 (typo)
BasicBlock::new(0) -> START_BLOCK [no functional changes] #108154 (BasicBlock::new(0) -> START_BLOCK [no functional changes])

Failed merges:

r? @ghost
@rustbot modify labels: rollup

This is what ISO C strongly implies this is correct, and many processor-specific ABIs imply or mandate this size, so "everyone" (LLVM, gcc...) defaults to emitting enums this way. However, this is by no means guaranteed by ISO C, and the bare-metal Arm targets show it can be overridden, which rustc supports via `c-enum-min-bits` in a target.json. The override is a flag named `-fshort-enums` in clang and gcc, but introducing a CLI flag is probably unnecessary for rustc. This flag can be used by non-Arm microcontroller targets, like AVR and MSP430, but it is not enabled for them by default. Rust programmers who know the size of a target's enums can use explicit reprs, which also lets them match C23 code. This change is most relevant to 16-bit targets: AVR and MSP430. Most of rustc's targets use 32-bit ints, but ILP64 does exist. Regardless, rustc should now correctly handle enums for both very small and very large targets. Thanks to William for confirming MSP430 behavior, and to Waffle for better style and no-core size_of asserts. Co-authored-by: William D. Jones <[email protected]> Co-authored-by: Waffle Maybe <[email protected]>

…16-bit-targets, r=WaffleLapkin Default `repr(C)` enums to `c_int` size This is what ISO C strongly implies this is correct, and many processor-specific ABIs imply or mandate this size, so "everyone" (LLVM, gcc...) defaults to emitting enums this way. However, this is by no means guaranteed by ISO C, and the bare-metal Arm targets show it can be overridden, which rustc supports via `c-enum-min-bits` in a target.json. The override is a flag named `-fshort-enums` in clang and gcc, but introducing a CLI flag is probably unnecessary for rustc. This flag can be used by non-Arm microcontroller targets, like AVR and MSP430, but it is not enabled for them by default. Rust programmers who know the size of a target's enums can use explicit reprs, which also lets them match C23 code. This change is most relevant to 16-bit targets: AVR and MSP430. Most of rustc's targets use 32-bit ints, but ILP64 does exist. Regardless, rustc should now correctly handle enums for both very small and very large targets. Thanks to William for confirming MSP430 behavior, and to Waffle for better style and no-core `size_of` asserts. Fixes rust-lang#107361 Fixes rust-lang#77806

Copy `bin/*` and `lib/*.dylib` files to `stage0-sysroot` Fixes rust-lang#101691

fix a line, and do a consistency fix

…Mark-Simulacrum Add compiler-errors to a few more triagebot groups Self-explanatory

typo

…mpiler-errors `BasicBlock::new(0)` -> `START_BLOCK` [no functional changes]

matthiaskrgr · 2023-02-17T11:39:24Z

@bors r+ rollup=never p=6

bors · 2023-02-17T11:39:26Z

📌 Commit ae5473c has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2023-02-17T14:27:31Z

⌛ Testing commit ae5473c with merge f722b24...

bors · 2023-02-17T17:42:44Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing f722b24 to master...

rust-timer · 2023-02-17T17:44:27Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#108154	3f1664a87e637714bb7c5d0912f64f6f742d0c1a
#108149	5cc148065369492df456f2b1062484a9c24db25d
#108144	2fcba110c0736788d5791d4bff19197a383834aa
#108126	3a825094b6785a43d032b081227ef9a338ee2835
#107956	89394208c043edd910fa6c950968ca75fcf349c0
#107592	65316d8083377a664737d6891e0ce289c4660903

previous master: f4f5fc3e5c

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-02-17T18:48:34Z

Finished benchmarking commit (f722b24): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Warning ⚠: The following benchmark(s) failed to build:

rustc

cc @rust-lang/wg-compiler-performance

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

nnethercote · 2023-02-17T22:14:36Z

The bootstrapping perf test failed, which is weird. The last few lines of output with the error:

       [RUSTC-TIMING] getopts test:false 0.481
          Compiling proc_macro v0.0.0 (/home/collector/rustc-perf/rust/library/proc_macro)
       [RUSTC-TIMING] proc_macro test:false 2.640
          Compiling test v0.0.0 (/home/collector/rustc-perf/rust/library/test)
       [RUSTC-TIMING] test test:false 3.324
           Finished release [optimized] target(s) in 33.38s
       thread 'main' panicked at 'failed to copy `/home/collector/rustc-perf/target/release/build` to `/home/collector/rustc-perf/rust/build/x86_64-unknown-linux-gnu/stage0-sysroot/bin/build`: the source path is neither a regular file nor a symlink to a regular file', lib.rs:1419:17
       note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Strange. Has anything about the paths changed lately? I guess we can keep watching, see if this is a once-only failure or if it continues.

matthiaskrgr · 2023-02-17T23:14:39Z

Hm, the next merge commit also lacks any kind of benchmark...
I wonder if https://github.com/rust-lang/rust/pull/107956/files messed up things for the benchmark server somehow.

lqd · 2023-02-17T23:20:09Z

Only the bootstrap timings are missing, correct ? Make sure the following is toggled.

matthiaskrgr · 2023-02-17T23:23:27Z

Ugh 😅 could we make it say "No relevant results" instead of "No results" if there are results but that checkbox is not ticket? :/

Kobzol · 2023-02-19T15:20:50Z

Implemented here.

tshepang and others added 12 commits February 16, 2023 18:58

fix some lines, and do a consistency fix

f997231

Add compiler-errors to a few more triagebot groups

09359d2

Copy bin/* and lib/*.dylib files to stage0-sysroot

6990ab9

typo

ad8947c

BasicBlock::new(0) -> START_BLOCK [no functional changes]

c946494

Rollup merge of rust-lang#107956 - KittyBorgX:master, r=ozkanonur

9956766

Copy `bin/*` and `lib/*.dylib` files to `stage0-sysroot` Fixes rust-lang#101691

Rollup merge of rust-lang#108126 - tshepang:nits, r=lcnr

e53bd4c

fix a line, and do a consistency fix

Rollup merge of rust-lang#108144 - compiler-errors:triagebot-more, r=…

a8685eb

…Mark-Simulacrum Add compiler-errors to a few more triagebot groups Self-explanatory

Rollup merge of rust-lang#108149 - tshepang:typo, r=Dylan-DPC

392b150

typo

Rollup merge of rust-lang#108154 - scottmcm:start-block-cleanup, r=co…

ae5473c

…mpiler-errors `BasicBlock::new(0)` -> `START_BLOCK` [no functional changes]

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 17, 2023

bors merged commit f722b24 into rust-lang:master Feb 17, 2023

rustbot added this to the 1.69.0 milestone Feb 17, 2023

bors mentioned this pull request Feb 17, 2023

WIP: Remove ResumeTy from async lowering #107562

Draft

1 task

Kobzol mentioned this pull request Feb 19, 2023

Display "No relevant results" on compare page where there are filtered non-relevant results rust-lang/rustc-perf#1525

Merged

matthiaskrgr mentioned this pull request Aug 15, 2023

ICE: 'is_trivially_sized' applied to unexpected type #114872

Closed

matthiaskrgr mentioned this pull request Nov 18, 2023

ice: non_lifetime_binders: bound types encountered in structurally_relate_tys #118038

Open

matthiaskrgr mentioned this pull request Dec 24, 2023

ICE: predicates_of.rs: no entry found for key #119275

Closed

matthiaskrgr mentioned this pull request Jan 1, 2024

ICE: no entry found for key, expr.rs #119489

Closed

matthiaskrgr mentioned this pull request Feb 22, 2024

ICE: could not resolve DefId #121422

Closed

matthiaskrgr deleted the rollup-5k2j7cx branch March 16, 2024 18:18

matthiaskrgr mentioned this pull request Mar 27, 2024

ICE: unexpected infer type #123140

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 6 pull requests #108159

Rollup of 6 pull requests #108159

matthiaskrgr commented Feb 17, 2023

matthiaskrgr commented Feb 17, 2023

bors commented Feb 17, 2023

bors commented Feb 17, 2023

bors commented Feb 17, 2023

rust-timer commented Feb 17, 2023

rust-timer commented Feb 17, 2023

nnethercote commented Feb 17, 2023

matthiaskrgr commented Feb 17, 2023

lqd commented Feb 17, 2023

matthiaskrgr commented Feb 17, 2023

Kobzol commented Feb 19, 2023

Rollup of 6 pull requests #108159

Rollup of 6 pull requests #108159

Conversation

matthiaskrgr commented Feb 17, 2023

matthiaskrgr commented Feb 17, 2023

bors commented Feb 17, 2023

bors commented Feb 17, 2023

bors commented Feb 17, 2023

rust-timer commented Feb 17, 2023

rust-timer commented Feb 17, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

nnethercote commented Feb 17, 2023

matthiaskrgr commented Feb 17, 2023

lqd commented Feb 17, 2023

matthiaskrgr commented Feb 17, 2023

Kobzol commented Feb 19, 2023