-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring tests back into rustc source tarball #107239
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were missing after recent move from src/test to tests.
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
Jan 23, 2023
Edited to reflect that this fixes #107081 |
albertlarsan68
added
the
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
label
Jan 24, 2023
LGTM, but I don't have time for a full review. |
Mark-Simulacrum
added
beta-nominated
Nominated for backporting to the compiler in the beta channel.
beta-accepted
Accepted for backporting to the compiler in the beta channel.
labels
Jan 24, 2023
Accepting beta-backport as well, we need this for 1.68 tarballs and I'd rather avoid reverting the test move (it'll make backports more annoying). @bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jan 24, 2023
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 25, 2023
Bring tests back into rustc source tarball They were missing after recent move from src/test to tests. cc `@albertlarsan68` Fixes rust-lang#107081
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 25, 2023
Bring tests back into rustc source tarball They were missing after recent move from src/test to tests. cc ``@albertlarsan68`` Fixes rust-lang#107081
This was referenced Jan 25, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 25, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#105345 (Add hint for missing lifetime bound on trait object when type alias is used) - rust-lang#106897 (Tweak E0597) - rust-lang#106944 (Suggest using a lock for `*Cell: Sync` bounds) - rust-lang#107239 (Bring tests back into rustc source tarball) - rust-lang#107244 (rustdoc: rearrange HTML in primitive reference links) - rust-lang#107255 (add test where we ignore hr implied bounds) - rust-lang#107256 (Delete `SimplifyArmIdentity` and `SimplifyBranchSame` mir opts) - rust-lang#107266 (rustdoc: prohibit scroll bar on source viewer in Safari) - rust-lang#107282 (erica solver: implement builtin `Pointee` trait impl candidates) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Mark-Simulacrum
removed
the
beta-nominated
Nominated for backporting to the compiler in the beta channel.
label
Feb 14, 2023
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 15, 2023
…mulacrum [beta] backport * Do not eagerly recover for bad impl Trait types in macros rust-lang#107813 * Fix infinite loop in rustdoc get_all_import_attributes function rust-lang#107357 * Bring tests back into rustc source tarball rust-lang#107239 r? `@Mark-Simulacrum`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
beta-accepted
Accepted for backporting to the compiler in the beta channel.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were missing after recent move from src/test to tests.
cc @albertlarsan68
Fixes #107081