-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve spans of non-WF implied bound types #106582
Improve spans of non-WF implied bound types #106582
Conversation
r? @lcnr (rustbot has picked a reviewer for you, use r? to override) |
Some changes occurred in engine.rs, potentially modifying the public API of cc @lcnr |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit 43da833a38ffaf1f6d19b60e0e2ae268d5bacd9f with merge fcae9e715f30b082892a7fec6bf4f6d507e4f839... |
@bors try |
⌛ Trying commit 46c41c0536beb5ecb7dd3874e45bf29a17d336a2 with merge a8188b53dfc7f760291f2ab557a48326bf239f38... |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (a8188b53dfc7f760291f2ab557a48326bf239f38): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
46c41c0
to
e77e8eb
Compare
⌛ Testing commit e77e8eb with merge 8179a5027e8b7d2874bebf511df563fd2c6549e6... |
Bors is confused a nd thinks this is not a try build @bors retry |
@bors try |
⌛ Trying commit e77e8eb with merge 7adefe5110da12cdae3edf598363711f154d03a4... |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (7adefe5110da12cdae3edf598363711f154d03a4): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (c54c8cb): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
Fixes #60980