-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retry mechanism for rustdoc GUI tests to reduce flakyness #106449
Add retry mechanism for rustdoc GUI tests to reduce flakyness #106449
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
418cb4b
to
e36b5bf
Compare
e36b5bf
to
f902200
Compare
I added some documentation on the |
@bors r+ rollup=iffy |
☀️ Test successful - checks-actions |
Finished benchmarking commit (cc47b06): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
Part of #93784.
I added 3 retries for failing GUI tests. An important note: if more than half of total tests fail, I don't retry because it's very likely not flakyness anymore at this point but a missing update after changes.