-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump master bootstrap compiler #105741
Bump master bootstrap compiler #105741
Conversation
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
library/core/src/future/mod.rs
Outdated
@@ -62,7 +62,7 @@ unsafe impl Sync for ResumeTy {} | |||
/// better error messages (`impl Future` rather than `GenFuture<[closure.....]>`). | |||
// This is `const` to avoid extra errors after we recover from `const async fn` | |||
// FIXME(swatinem): This fn can be removed when bumping the bootstrap compiler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Swatinem can the entire function be removed now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the unknown lang items for now, IMO it's fine to merge this if it builds and cleanup the functions (if needed) later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the idea was that this whole function can be removed now, as it is now unused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to see a separate PR with more expansive cleanup, but I think minimal work as part of this PR is best.
r=me modulo CI |
This comment has been minimized.
This comment has been minimized.
@bors r=Mark-Simulacrum p=1 |
📌 Commit 8c30ada576d7ef079c666e6ff7f07b492f8359a3 has been approved by It is now in the queue for this repository. |
⌛ Testing commit 8c30ada576d7ef079c666e6ff7f07b492f8359a3 with merge a3fd12238cca733fe3e05880c2d13ab942af30bf... |
💔 Test failed - checks-actions |
@bors r=Mark-Simulacrum |
📌 Commit 0191c5e13dc865e270741be2c942e58f75ebfbfb has been approved by It is now in the queue for this repository. |
⌛ Testing commit 0191c5e13dc865e270741be2c942e58f75ebfbfb with merge 9cc6ef7298ac57aa15ddfd8c444a24f395fd691a... |
💔 Test failed - checks-actions |
⌛ Testing commit fbe0450 with merge 0354138d267a6b4e3191a8b91bbd5e67df1455f5... |
💔 Test failed - checks-actions |
Apparently #105800 is still not enough to make |
This comment has been minimized.
This comment has been minimized.
Stage0 LTO seems to be fixed with this patch. I have no idea if that makes sense though, and it might be better to just disable stage0 LTO, because it takes forever for little benefit. diff --git a/src/bootstrap/compile.rs b/src/bootstrap/compile.rs
index ae5dfdea19f..c8aa8c99163 100644
--- a/src/bootstrap/compile.rs
+++ b/src/bootstrap/compile.rs
@@ -362,12 +362,7 @@ pub fn std_cargo(builder: &Builder<'_>, target: TargetSelection, stage: u32, car
// built with bitcode so that the produced rlibs can be used for both LTO
// builds (which use bitcode) and non-LTO builds (which use object code).
// So we override the override here!
- //
- // But we don't bother for the stage 0 compiler because it's never used
- // with LTO.
- if stage >= 1 {
- cargo.rustflag("-Cembed-bitcode=yes");
- }
+ cargo.rustflag("-Cembed-bitcode=yes");
// By default, rustc does not include unwind tables unless they are required
// for a particular target. They are not required by RISC-V targets, but |
8c80dd9
to
cc4e434
Compare
Restored the gate on stage 0, but also dropped an explicit cfg(bootstrap) in the comment. I'm not sure we actually want cfg(bootstrap) there -- doing LTO in stage 0 doesn't feel very helpful. @bors r+ rollup=never |
☀️ Test successful - checks-actions |
Finished benchmarking commit (b15ca66): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
These benchmarks are historically prone to noise and this change is required regardless. |
This PR bumps the bootstrap compiler to the beta created earlier this week, cherry-picks the stabilization version number updates, and updates the
cfg(bootstrap)
s.r? @Mark-Simulacrum