-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set download-ci-llvm = "if-available"
by default when channel = dev
#104512
Conversation
For future work, another thing we could do is change the default profile to |
1f8bd19
to
574cccc
Compare
This comment has been minimized.
This comment has been minimized.
…ev"` See rust-lang/compiler-team#566. The motivation for changing the default is to avoid downloading and building LLVM when someone runs `x build` before running `x setup`. The motivation for only doing it on `channel = "dev"` is to avoid breaking distros or users installing from source. It works because `dev` is also the default channel. The diff looks larger than it is; most of it is moving the `llvm` branch below the `rust` so `config.channel` is set.
574cccc
to
ac67262
Compare
@bors r+ |
⌛ Testing commit ac67262 with merge 4a913d5df06ed53fb3d32fcc1c42fe00acbcfc6a... |
💔 Test failed - checks-actions |
Unrelated to this PR, looks like https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Authentication.20failed.20on.20merge.20attempt @bors retry |
The job Click to see the possible cause of the failure (guessed by this bot)
|
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#98391 (Reimplement std's thread parker on top of events on SGX) - rust-lang#104019 (Compute generator sizes with `-Zprint_type_sizes`) - rust-lang#104512 (Set `download-ci-llvm = "if-available"` by default when `channel = dev`) - rust-lang#104901 (Implement masking in FileType comparison on Unix) - rust-lang#105082 (Fix Async Generator ABI) - rust-lang#105109 (Add LLVM KCFI support to the Rust compiler) - rust-lang#105505 (Don't warn about unused parens when they are used by yeet expr) - rust-lang#105514 (Introduce `Span::is_visible`) - rust-lang#105516 (Update cargo) - rust-lang#105522 (Remove wrong note for short circuiting operators) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
See rust-lang/compiler-team#566. The motivation for changing the default is to avoid downloading and building LLVM when someone runs
x build
before runningx setup
. The motivation for only doing it onchannel = "dev"
is to avoid breaking distros or users installing from source. It works becausedev
is also the default channel.The diff looks larger than it is; most of it is moving the
llvm
branch below therust
soconfig.channel
is set.r? @Mark-Simulacrum cc @oli-obk @bjorn3 @cuviper