-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: remove redundant font-color CSS on .where
#104503
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before 7f6ce7d, light-theme where clauses had color `#4E4C4C` while the main color was `#000`. One of that commit's simplifications made it so that everything used the same black.
r? @jsha (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Nov 16, 2022
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
GuillaumeGomez
approved these changes
Nov 16, 2022
@bors r+ rollup |
🌲 The tree is currently closed for pull requests below priority 1. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 16, 2022
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 17, 2022
…aumeGomez rustdoc: remove redundant font-color CSS on `.where` Before 7f6ce7d, light-theme where clauses had color `#4E4C4C` while the main color was `#000`. One of that commit's simplifications made it so that everything used the same black.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 17, 2022
…aumeGomez rustdoc: remove redundant font-color CSS on `.where` Before 7f6ce7d, light-theme where clauses had color `#4E4C4C` while the main color was `#000`. One of that commit's simplifications made it so that everything used the same black.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 17, 2022
…aumeGomez rustdoc: remove redundant font-color CSS on `.where` Before 7f6ce7d, light-theme where clauses had color `#4E4C4C` while the main color was `#000`. One of that commit's simplifications made it so that everything used the same black.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 18, 2022
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#103852 (Don't remap early-bound regions for return-position `impl Trait` in trait originating from `impl`) - rust-lang#104366 (Simplify settings theme choice) - rust-lang#104433 (Fix `emit_unused_delims_expr` ICE) - rust-lang#104444 (Fix ICE in in_operand for ty error) - rust-lang#104483 (Convert predicates into Predicate in the Obligation constructor) - rust-lang#104496 (Don't attempt to normalize compiler backtraces) - rust-lang#104503 (rustdoc: remove redundant font-color CSS on `.where`) - rust-lang#104508 (Check `dyn*` return type correctly) - rust-lang#104515 (ICE fixing, remove is_tainted_by_errors since we have ty_error for delay bug) - rust-lang#104532 (Migrate tooltip style to CSS variables) - rust-lang#104545 (Readd the matches_macro diag item) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before 7f6ce7d, light-theme where clauses had color
#4E4C4C
while the main color was#000
. One of that commit's simplifications made it so that everything used the same black.