-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: a few fixes #10421
doc: a few fixes #10421
Conversation
adrientetar
commented
Nov 11, 2013
- Closes Rustdoc: monospaced font appears too large on a Retina display #10330
- Improves on doc: CodeMirror should ignore 'static/'self #9873
- Adds favicon for tutorial files
@alexcrichton How does it looks? |
It's not really necessary to use Also, it still seems like there's quite a few flags shared among all the rules:
etc. |
@alexcrichton Long lines but oh well. So I made flags for each filetype. |
You can interpolate makefile variables into others, so you can have a scheme like: BASE_PANDOC_OPTS := -a -b -c
TEX_OPTS = $(BASE_PANDOC_OPTS) -d -e -f
HTML_OPTS = $(BASE_PANDOC_OPTS) -h -i -j |
@alexcrichton Done. What's the difference between |
There is a difference in makefile land, but to me it's just magical. I normally just pick the one that works and/or doesn't spit out errors. That being said, the actual difference is that |
@alexcrichton Can you r+ again? I just updated a reference for #10423. ty! |
@alexcrichton Nasty bitrot. |
CodeMirror parser errors are related to rust-lang#9873.
Since tutorial/manual files are stored on static.rust-lang.org, browsers try to fetch the favicon from there while it should be retrieved from the main domain.
@alexcrichton Fixed. |
Fix `almost_swapped` false positive (`let mut a = b; a = a`) Fixes `2` in rust-lang#10421 changelog: [`almost_swapped`]: Fix false positive when a variable is changed to itself. (`a = a`)
fix `almost_swapped`: Ignore external macros Fixes rust-lang#10421 ; Related to rust-lang#10499 (Fixing points *1* and *3* from rust-lang#10421) changelog: [`almost_swapped`]: Add a check to ignore external macros