Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specialize iter::ArrayChunks::fold for TrustedRandomAccess iterators #103446

Merged
merged 5 commits into from
Nov 8, 2022
Merged

Specialize iter::ArrayChunks::fold for TrustedRandomAccess iterators #103446

merged 5 commits into from
Nov 8, 2022

Commits on Nov 7, 2022

  1. add benchmark for iter::ArrayChunks::fold specialization 

    This also updates the existing iter::Copied::next_chunk benchmark so
that the thing it benches doesn't get masked by the ArrayChunks specialization
    @the8472
    the8472 committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    b00666e View commit details
    Browse the repository at this point in the history

  2. make the array initialization guard available to other modules

    @the8472
    the8472 committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    eb3f001 View commit details
    Browse the repository at this point in the history

  3. specialize iter::ArrayChunks::fold for TrustedRandomAccess iters 

    This is fairly safe use of TRA since it consumes the iterator so
no struct in an unsafe state will be left exposed to user code
    @the8472
    the8472 committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    cfcce8e View commit details
    Browse the repository at this point in the history

  4. simplification: do not process the ArrayChunks remainder in fold()

    @the8472
    the8472 committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    43c353f View commit details
    Browse the repository at this point in the history

  5. document and improve array Guard type 

    The type is unsafe and now exposed to the whole crate.
Document it properly and add an unsafe method so the
caller can make it visible that something unsafe is happening.
    @the8472
    the8472 committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    3925fc0 View commit details
    Browse the repository at this point in the history