Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fire rust_2021_incompatible_closure_captures in edition = 2021 crates #101409

Conversation

WaffleLapkin
Copy link
Member

Fixes #101284

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 4, 2022
@rust-highfive
Copy link
Collaborator

r? @TaKO8Ki

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 4, 2022
@rust-log-analyzer

This comment has been minimized.

@WaffleLapkin WaffleLapkin force-pushed the rust_2021_compatibility_no_warn_in_2021_crates branch from c631c55 to fcd42d6 Compare September 4, 2022 16:05
@TaKO8Ki
Copy link
Member

TaKO8Ki commented Sep 5, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 5, 2022

📌 Commit fcd42d6 has been approved by TaKO8Ki

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 5, 2022
Rollup of 6 pull requests

Successful merges:

 - rust-lang#101142 (Improve HIR stats)
 - rust-lang#101367 (Suggest `{Option,Result}::{copied,clone}()` to satisfy type mismatch)
 - rust-lang#101391 (more clippy::perf fixes)
 - rust-lang#101409 (Don't fire `rust_2021_incompatible_closure_captures` in `edition = 2021` crates)
 - rust-lang#101420 (Fix `hir::Local` doc to match with the variable name used: `init`)
 - rust-lang#101429 (Don't suggest reborrow if usage is inside a closure)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3a9e2ff into rust-lang:master Sep 5, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rust-2021-incompatible-closure-captures fires in 2021 edition code
6 participants