rustdoc: remove old CSS selector that causes weird spacing #101335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
|
r? @jsha (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Sep 2, 2022
|
Thanks! r=me once CI pass. |
|
@GuillaumeGomez Never mind. I misunderstood some of the code (confused Turns out you can still get this CSS reachable. |
|
@GuillaumeGomez However, I'm a bit curious if we actually want this CSS here. It still seems outdated, because when I manage to trigger it, the results look worse to me than if it were gone. |
|
If it creates ugly output when triggered, I'd say it's possible if it gets removed. |
GuillaumeGomez
approved these changes
Sep 2, 2022
|
r=me once CI pass then! |
|
@GuillaumeGomez I posted some screenshots and links to samples. Do you think the "this is what we get if we merge this PR" version looks better than the old one? |
notriddle
changed the title
.methods > .item-info
It was added with e08a84a (actually, it was called `.methods > .stability` at the time) and was directly nested that way. But with the switch to `<details>`, the code has changed drastically out from under it, to the point where you have to go out of your way to actually get it to render this way, and the result looks overly-tight and weird alongside the normal version where this code is not reachable.
notriddle
force-pushed
the
notriddle/methods-stability
branch
from
3f070c4
to
df09047
Compare
|
Oh I see. So it has an impact when there is no doc block. Maybe we need to update: .content .impl-items > .item-info {
margin-left: 32px;
}so they still are aligned? Adding a GUI test for it would be nice too. |
|
Can upload the updated version too please? |
|
@GuillaumeGomez It's uploaded. |
|
Apart from the small potential improvement in the GUI test, looks great! 👍 |
notriddle
force-pushed
the
notriddle/methods-stability
branch
from
0d59fe3
to
17622fc
Compare
notriddle
force-pushed
the
notriddle/methods-stability
branch
from
17622fc
to
0f29824
Compare
GuillaumeGomez
approved these changes
Sep 2, 2022
|
Thanks! r=me once CI pass |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 3, 2022
…ity, r=notriddle rustdoc: remove old CSS selector that causes weird spacing It was added with e08a84a (actually, it was called `.methods > .stability` at the time) and was directly nested that way. **EDIT**: It is technically reachable code still, but it seems wrong. ## With the old CSS rule still present https://notriddle.com/notriddle-rustdoc-test/weird-spacing/lib/struct.Foo.html  ## Version 2 (an older version of this PR) https://notriddle.com/notriddle-rustdoc-test/normal-spacing-2/lib/struct.Foo.html  ## Version 3 (with alignment fix for mobile) https://notriddle.com/notriddle-rustdoc-test/normal-spacing-3/lib/struct.Foo.html 
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 3, 2022
…ity, r=notriddle rustdoc: remove old CSS selector that causes weird spacing It was added with e08a84a (actually, it was called `.methods > .stability` at the time) and was directly nested that way. **EDIT**: It is technically reachable code still, but it seems wrong. ## With the old CSS rule still present https://notriddle.com/notriddle-rustdoc-test/weird-spacing/lib/struct.Foo.html  ## Version 2 (an older version of this PR) https://notriddle.com/notriddle-rustdoc-test/normal-spacing-2/lib/struct.Foo.html  ## Version 3 (with alignment fix for mobile) https://notriddle.com/notriddle-rustdoc-test/normal-spacing-3/lib/struct.Foo.html 
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 3, 2022
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#101335 (rustdoc: remove old CSS selector that causes weird spacing) - rust-lang#101347 (ffx component run should provide a collection) - rust-lang#101364 (Shrink suggestion span of argument mismatch error) - rust-lang#101365 (remove redundant clones) Failed merges: - rust-lang#101349 (rustdoc: remove `.impl-items { flex-basis }` CSS, not in flex container) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was added with e08a84a (actually, it was called
.methods > .stabilityat the time) and was directly nested that way.EDIT: It is technically reachable code still, but it seems wrong.
With the old CSS rule still present
https://notriddle.com/notriddle-rustdoc-test/weird-spacing/lib/struct.Foo.html
Version 2 (an older version of this PR)
https://notriddle.com/notriddle-rustdoc-test/normal-spacing-2/lib/struct.Foo.html
Version 3 (with alignment fix for mobile)
https://notriddle.com/notriddle-rustdoc-test/normal-spacing-3/lib/struct.Foo.html