-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix internal doc link #101322
Fix internal doc link #101322
Conversation
The doc link from `DedupSortedIter` to `BTreeMap::bulk_build_from_sorted_iter` was broken when building internal documentation,
(rust-highfive has picked a reviewer for you, use r? to override) |
Can you also add that configuration to mingw-check's doc check? That way we fix this permanently (for std at least). I think it should be largely a superset of public items, so hopefully only helps. (r=me with that done) |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
@bors r=Mark-Simulacrum rollup |
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#101322 (Fix internal doc link) - rust-lang#101385 (updated description of File struct in std::fs) - rust-lang#101388 (Don't delay invalid LHS bug unless it will be covered by an error in `check_overloaded_binop`) - rust-lang#101394 (Forbid mixing `System` with direct sytem allocator calls) - rust-lang#101397 (rustdoc: remove redundant mobile-sized `.source nav:not(.sidebar).sub`) - rust-lang#101401 (Make `char::is_lowercase` and `char::is_uppercase` const) - rust-lang#101407 (Remove duplicated test (superseeded by search-form-elements.goml)) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
@@ -45,7 +45,8 @@ ENV SCRIPT python3 ../x.py --stage 2 test src/tools/expand-yaml-anchors && \ | |||
python3 ../x.py test --stage 0 src/tools/compiletest && \ | |||
python3 ../x.py test --stage 2 src/tools/tidy && \ | |||
python3 ../x.py test --stage 0 core alloc std test proc_macro && \ | |||
python3 ../x.py doc --stage 0 library/test && \ | |||
# Build both public and internal documentation. | |||
RUSTDOCFLAGS="--document-private-items" python3 ../x.py doc --stage 0 library/test && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't mind adding --document-hidden-items
here, we could close #87844.
The doc link from
DedupSortedIter
toBTreeMap::bulk_build_from_sorted_iter
was broken when building internal documentation,This prevented me from building internal documentation locally: