-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert let_chains stabilization #100812
Revert let_chains stabilization #100812
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
452e799
to
aa0b40e
Compare
Removing |
@bors r+ rollup=iffy |
📌 Commit aa0b40ef6c70f29a2c98a9faa2b6b7cd706ab120 has been approved by It is now in the queue for this repository. |
☔ The latest upstream changes (presumably #100868) made this pull request unmergeable. Please resolve the merge conflicts. |
I'm a little busy this week, I should get to it next week. |
This is needed for the revert of let_chains.
This reverts commit 3266460. This is the revert against master, the beta revert was already done in rust-lang#100538.
aa0b40e
to
01acfef
Compare
@Mark-Simulacrum done, I also migrated the one "new" diagnostic to session diagnostics. Also, I think this should probably get p=1 since this is pretty bitrotty as it seems |
@bors r=Mark-Simulacrum rollup=never p=1 |
☀️ Test successful - checks-actions |
Finished benchmarking commit (a0d0709): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
This is the revert against master, the beta revert was already done in #100538.
Bumps the stage0 compiler which already has it reverted.