Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #100611

Merged
merged 15 commits into from
Aug 16, 2022
Merged

Rollup of 6 pull requests #100611

merged 15 commits into from
Aug 16, 2022

Commits on Aug 11, 2022

  1. Add support for generating unique *.profraw files by default when usi…

    …ng the `-C instrument-coverage` flag.
    
    Respond to PR comments.
    ridwanabdillahi committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    1008822 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. Configuration menu
    Copy the full SHA
    804579c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7e49c1b View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2022

  1. Configuration menu
    Copy the full SHA
    2970ad8 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. Add missing closing quote

    Rageking8 authored Aug 15, 2022
    Configuration menu
    Copy the full SHA
    ba2c2a6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4d1b5f0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    12e609b View commit details
    Browse the repository at this point in the history
  4. when there are 3 or more return statements in the loop

    emit the first 3 errors and duplicated diagnostic information
    using take of iterator for the first third return
    	modified:   compiler/rustc_typeck/src/check/coercion.rs
    	new file:   src/test/ui/typeck/issue-100285.rs
    	new file:   src/test/ui/typeck/issue-100285.stderr
    Yiming Lei committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    0471e27 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a5cc3a0 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2022

  1. Rollup merge of rust-lang#100338 - lyming2007:issue-100285-fix, r=pet…

    …rochenkov
    
    when there are 3 or more return statements in the loop
    
    emit the first 3 errors and duplicated diagnostic information
    	modified:   compiler/rustc_typeck/src/check/coercion.rs
    	new file:   src/test/ui/typeck/issue-100285.rs
    	new file:   src/test/ui/typeck/issue-100285.stderr
    matthiaskrgr authored Aug 16, 2022
    Configuration menu
    Copy the full SHA
    836f706 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#100384 - ridwanabdillahi:instr_profile_outp…

    …ut, r=wesleywiser
    
    Add support for generating unique profraw files by default when using `-C instrument-coverage`
    
    Currently, enabling the rustc flag `-C instrument-coverage` instruments the given crate and by default uses the naming scheme `default.profraw` for any instrumented profile files generated during the execution of a binary linked against this crate. This leads to multiple binaries being executed overwriting one another and causing only the last executable run to contain actual coverage results.
    
    This can be overridden by manually setting the environment variable `LLVM_PROFILE_FILE` to use a unique naming scheme.
    
    This PR adds a change to add support for a reasonable default for rustc to use when enabling coverage instrumentation similar to how the Rust compiler treats generating these same `profraw` files when PGO is enabled.
    
    The new naming scheme is set to `default_%m_%p.profraw` to ensure the uniqueness of each file being generated using [LLVMs special pattern strings](https://clang.llvm.org/docs/SourceBasedCodeCoverage.html#running-the-instrumented-program).
    
    Today the compiler sets the default for PGO `profraw` files to `default_%m.profraw` to ensure a unique file for each run. The same can be done for the instrumented profile files generated via the `-C instrument-coverage` flag as well which LLVM has API support for.
    
    Linked Issue: rust-lang#100381
    
    r? `@wesleywiser`
    matthiaskrgr authored Aug 16, 2022
    Configuration menu
    Copy the full SHA
    f347c42 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#100460 - cuviper:drop-llvm-12, r=nagisa

    Update the minimum external LLVM to 13
    
    With this change, we'll have stable support for LLVM 13 through 15 (pending release).
    For reference, the previous increase to LLVM 12 was rust-lang#90175.
    
    r? `@nagisa`
    matthiaskrgr authored Aug 16, 2022
    Configuration menu
    Copy the full SHA
    0b19a18 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fc735b0 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#100590 - TaKO8Ki:suggest-adding-array-lengt…

    …h, r=compiler-errors
    
    Suggest adding an array length if possible
    
    fixes rust-lang#100448
    matthiaskrgr authored Aug 16, 2022
    Configuration menu
    Copy the full SHA
    76dd166 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#100600 - saethlin:rename-memory-hooks, r=Ra…

    …lfJung
    
    Rename Machine memory hooks to suggest when they run
    
    Some of the other memory hooks start with `before_` or `after_` to indicate that they run before or after a certain operation. These don't, so I was a bit confused as to when they are supposed to run.
    
    `memory_read` can be read two ways in English, "memory was read" or "this is a memory read" so without the prefix this was especially ambiguous.
    matthiaskrgr authored Aug 16, 2022
    Configuration menu
    Copy the full SHA
    88af506 View commit details
    Browse the repository at this point in the history