Rollup of 8 pull requests #100356
Merged
Rollup of 8 pull requests #100356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reflects the concensus from the libs team as reported at rust-lang#70887 (comment) Co-authored-by: Yosh Wuyts <[email protected]>
Signed-off-by: Vincenzo Palazzo <[email protected]>
Stabilize backtrace This PR stabilizes the std::backtrace module. As of rust-lang#99431, the std::Error::backtrace item has been removed, and so the rest of the backtrace feature is set to be stabilized. Previous discussion can be found in rust-lang#72981, rust-lang#3156. Stabilized API summary: ```rust pub mod std { pub mod backtrace { pub struct Backtrace { } pub enum BacktraceStatus { Unsupported, Disabled, Captured, } impl fmt::Debug for Backtrace {} impl Backtrace { pub fn capture() -> Backtrace; pub fn force_capture() -> Backtrace; pub const fn disabled() -> Backtrace; pub fn status(&self) -> BacktraceStatus; } impl fmt::Display for Backtrace {} } } ``` `@yaahc`
…oerister Add error if link_ordinal used with unsupported link kind The `link_ordinal` attribute only has an affect if the `raw-dylib` link kind is used, so add an error if it is used with any other link kind.
…eiser Add more `// unit-test`s to MIR opt tests I only changed things which are hopefully completely uninteresting. I plan to submit more PRs that cover more files, but those cases will need some more complicated (and hence possibly controversial) changes, so I'll try and submit those in reasonably sized batches. r? rust-lang/wg-mir-opt
Rename integer log* methods to ilog* This reflects the concensus from the libs team as reported at rust-lang#70887 (comment). Joint work with `@yoshuawuyts.`
…before-array, r=fee1-dead Suggest a missing semicolon before an array fixes rust-lang#99658
…errors Iterate generics_def_id_map in reverse order to fix P-critical issue Closes rust-lang#100187 Fixes a `P-critical` beta regression.
…oc, r=joshtriplett docs: remove repetition in `is_numeric` function docs In rust-lang#99628 we introduce new docs for the `is_numeric` function, and this is a follow-up PR that removes some unnecessary repetition that may be introduced by some rebasing. `@rustbot` r? `@joshtriplett`
rustbot
added
T-compiler
|
@bors r+ rollup=never p=8 |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Aug 10, 2022
Tested on commit rust-lang/rust@1603a70. Direct link to PR: <rust-lang/rust#100356> 💔 miri on windows: test-pass → test-fail (cc @oli-obk @RalfJung). 💔 miri on linux: test-pass → test-fail (cc @oli-obk @RalfJung).
|
Finished benchmarking commit (1603a70): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesThis benchmark run did not return any relevant results for this metric. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Update cargo 7 commits in 4fd148c47e733770c537efac5220744945d572ef..ce40690a5e4e315d3dab0aae1eae69d0252c52ac 2022-08-03 15:03:52 +0000 to 2022-08-09 22:32:17 +0000 - Make the `rust-version` error recommend `cargo update --precise -p crate@ver` (rust-lang/cargo#10891) - resolver docs: link to version requirements syntax full explanation (rust-lang/cargo#10946) - Bump os_info to 3.5.0 (rust-lang/cargo#10943) - Mark --timings=html unstable in the document (rust-lang/cargo#10941) - Mention that aliases are recursive (rust-lang/cargo#10935) - Test if reserved filenames are allowed in Windows (rust-lang/cargo#10322) - improve error message for `no such subcommand` (rust-lang/cargo#10924)
|
📌 Perf builds for each rolled up PR:
In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
// unit-tests to MIR opt tests #100086 (Add more// unit-tests to MIR opt tests)is_numericfunction docs #100345 (docs: remove repetition inis_numericfunction docs)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup