Fix backwards-compatibility check for tests with +whole-archive
#100068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
dcsommer
commented
Aug 2, 2022
|
@bors r+ |
bors
added
S-waiting-on-bors
|
Beta-nominating, the mistake was introduced in 1.61. Also stable-nominating for the unlikely case of a point release, but this fix by itself doesn't deserve a point release. |
petrochenkov
added
beta-nominated
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 3, 2022
Fix backwards-compatibility check for tests with `+whole-archive` Fixes rust-lang#100066
This was referenced Aug 3, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 4, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#98877 (Set llvm configs when building lld) - rust-lang#100068 (Fix backwards-compatibility check for tests with `+whole-archive`) - rust-lang#100083 (rustdoc: use a more compact encoding for source-files.js) - rust-lang#100102 (Fix typo) - rust-lang#100104 (Remove more Clean trait implementations) - rust-lang#100105 (Add regression test for rust-lang#90871) - rust-lang#100107 (fix trailing whitespace in error message) - rust-lang#100111 (Provide suggestion on missing `let` in binding statement) - rust-lang#100119 (FilesTimes support does not build for ESP-IDF) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
rustbot
added
beta-accepted
Mark-Simulacrum
removed
the
beta-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 5, 2022
…mulacrum [beta] Rollup of beta backports Includes the following PRs: * rustc-docs: Be less specific about the representation of +bundle rust-lang#100074 * Fix backwards-compatibility check for tests with +whole-archive rust-lang#100068 * Revert write! and writeln! to late drop temporaries rust-lang#99689 * Upgrade indexmap and thorin-dwp to use hashbrown 0.12 rust-lang#99251 * rustdoc: avoid inlining modules with duplicate names rust-lang#99738 r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100066