Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-D warnings should deny warnings from lint renames #94500

Open
daprilik opened this issue Mar 1, 2022 · 3 comments
Open

-D warnings should deny warnings from lint renames #94500

daprilik opened this issue Mar 1, 2022 · 3 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@daprilik
Copy link

daprilik commented Mar 1, 2022

Description

e.g: setting -W clippy::disallowed_type -D warnings when invoking clippy currently results in the following warning:

warning: lint `clippy::disallowed_type` has been renamed to `clippy::disallowed_types`
  |
  = note: requested on the command line with `-W clippy::disallowed_type`

...when this should be a hard error (due to the -D warnings)

Version

rustc 1.59.0 (9d1b2106e 2022-02-23)
binary: rustc
commit-hash: 9d1b2106e23b1abd32fce1f17267604a5102f57a
commit-date: 2022-02-23
host: x86_64-pc-windows-msvc
release: 1.59.0
LLVM version: 13.0.0
@daprilik daprilik added A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 1, 2022
@daprilik
Copy link
Author

daprilik commented Mar 1, 2022

(cross posted from rust-lang/rust-clippy#8485)

@jyn514
Copy link
Member

jyn514 commented Mar 3, 2022

Hmm, I would have expected this to be fixed by #82620. Maybe I missed lints that are denied using the CLI.

@ehuss
Copy link
Contributor

ehuss commented Mar 3, 2022

It's because it is using struct_warn which is not a lint, and thus not affected by lint controls. There's an MCP to change that, but it never went anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants