Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: rustdoc resolution failures #93380

Closed
Mark-Simulacrum opened this issue Jan 27, 2022 · 5 comments
Closed

regression: rustdoc resolution failures #93380

Mark-Simulacrum opened this issue Jan 27, 2022 · 5 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Milestone

Comments

@Mark-Simulacrum Mark-Simulacrum added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Jan 27, 2022
@Mark-Simulacrum Mark-Simulacrum added this to the 1.59.0 milestone Jan 27, 2022
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jan 27, 2022
@Nemo157
Copy link
Member

Nemo157 commented Jan 27, 2022

It seems like cargo is not building all the dependencies or passing the --extern flags to the rustdoc invocation for some reason.

@Nemo157
Copy link
Member

Nemo157 commented Jan 27, 2022

At least some of the dependencies I've checked (textwrap-macros-impl and deepmesa-collections) have set lib.doc = false in their Cargo.toml; maybe related?

@Mark-Simulacrum
Copy link
Member Author

cc @ehuss -- I think this was recently fixed and backported, right?

@Nemo157
Copy link
Member

Nemo157 commented Jan 27, 2022

Ah yes, updating to 1.59.0-beta.4 the deepmesa and textwrap-macros builds succeed, it looks like the crater run was on beta.3.

@Mark-Simulacrum Mark-Simulacrum removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jan 27, 2022
@Mark-Simulacrum
Copy link
Member Author

OK, closing as fixed then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants