Switch rustdoc to Rust 2021 #89074
Assignees
Labels
A-edition-2021
Area: The 2021 edition
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Comments
camelid
added
T-rustdoc
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Sep 28, 2021
Migrate in-tree crates to 2021 This replaces rust-lang#89075 (cherry picking some of the commits from there), and closes rust-lang#88637 and fixes rust-lang#89074. It excludes a migration of the library crates for now (see tidy diff) because we have some pending bugs around macro spans to fix there. I instrumented bootstrap during the migration to make sure all crates moved from 2018 to 2021 had the compatibility warnings applied first. Originally, the intent was to support cargo fix --edition within bootstrap, but this proved fairly difficult to pull off. We'd need to architect the check functionality to support running cargo check and cargo fix within the same x.py invocation, and only resetting sysroots on check. Further, it was found that cargo fix doesn't behave too well with "not quite workspaces", such as Clippy which has several crates. Bootstrap runs with --manifest-path ... for all the tools, and this makes cargo fix only attempt migration for that crate. We can't use e.g. --workspace due to needing to maintain sysroots for different phases of compilation appropriately. It is recommended to skip the mass migration of Cargo.toml's to 2021 for review purposes; you can also use `git diff d6cd2c6 -I'^edition = .20...$'` to ignore the edition = 2018/21 lines in the diff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See also #88637.
The text was updated successfully, but these errors were encountered: