-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fn_sig
query panicks for specific malformed program.
#84569
Comments
Now #84401 is ready to land, let me think more about this.
It seems i need to break this chain somewhere in the list. Do you have any mentoring advice here, @petrochenkov? |
@crlf0710 I would expect anything with a DefId has a HirId - I would either abort early (before allocating the DefId) or allocate a HirId to go along with it. |
@jyn514 Thanks! Let me give it a try. |
The linked PR was merged and I'm not aware of any bugs, they should be tracked separately anyways. |
During implementation of #84401, i found that
fn_sig
query panicks for a specific malformed test case:test/ui/proc-macro/issue-59191-replace-root-with-fn.rs
In #84401 I plan to make the compilation abort after the error is raised, but it would be nice to allow it to continue.
The text was updated successfully, but these errors were encountered: