Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Box docs collapse implementations by default on nightly #84558

Closed
camelid opened this issue Apr 25, 2021 · 1 comment · Fixed by #84552
Closed

rustdoc: Box docs collapse implementations by default on nightly #84558

camelid opened this issue Apr 25, 2021 · 1 comment · Fixed by #84552
Labels
C-bug Category: This is a bug. E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@camelid
Copy link
Member

camelid commented Apr 25, 2021

This means that the docs are annoying to read and much less accessible for newcomers. Also, links to Box methods (such as Box::pin()) don't go to the method, and instead go to the top of the Box docs, with all the implementations collapsed.

nightly

image

beta (and stable)

image
@camelid camelid added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. C-bug Category: This is a bug. E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc T-rustdoc labels Apr 25, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Apr 25, 2021
@camelid camelid mentioned this issue Apr 25, 2021
Merged
@jyn514 jyn514 mentioned this issue Apr 26, 2021
Closed
@bors bors closed this as completed in 6eb956f Apr 27, 2021
@camelid
Copy link
Member Author

camelid commented Apr 27, 2021

Should be fixed on next nightly.

@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Open impl blocks by default GuillaumeGomez/rust
3 participants
@apiraino @camelid @rustbot