Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc lint listing code snippets don't have any indentation #79748

Closed
camelid opened this issue Dec 5, 2020 · 2 comments · Fixed by #79750
Closed

rustc lint listing code snippets don't have any indentation #79748

camelid opened this issue Dec 5, 2020 · 2 comments · Fixed by #79750
Assignees
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. P-high High priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly.

Comments

@camelid
Copy link
Member

camelid commented Dec 5, 2020

It used to (on stable and beta) look like this:

image

But on nightly it looks like:

image

The source code for the snippet is:

    /// ### Example
    ///
    /// ```rust
    /// if let _ = 123 {
    ///     println!("always runs!");
    /// }
    /// ```

This is true for other code snippets in the lint listing, though the rest of the book (and other books) don't have the issue.

@camelid camelid added A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools labels Dec 5, 2020
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Dec 5, 2020
@camelid
Copy link
Member Author

camelid commented Dec 5, 2020

cc @ehuss since you're the only one who's touched lint-docs since September

@camelid camelid self-assigned this Dec 5, 2020
@camelid camelid added P-high High priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Dec 6, 2020
@camelid
Copy link
Member Author

camelid commented Dec 6, 2020

Assigning P-high and removing I-prioritize as discussed in the prioritization working group.

@bors bors closed this as completed in 2872937 Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. P-high High priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants