Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move download-ci-llvm logic from bootstrap.py to rustbuild #77977

Closed
alarsyo opened this issue Oct 15, 2020 · 3 comments
Closed

move download-ci-llvm logic from bootstrap.py to rustbuild #77977

alarsyo opened this issue Oct 15, 2020 · 3 comments
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@alarsyo
Copy link
Contributor

alarsyo commented Oct 15, 2020

As discussed a bit in the comments of #77756 , it'd be great if the logic handling LLVM setup / download was integrated with rustbuild directly. The main blocker being that rustbuild would need to depend on an http client library.

Currently, the python script does system calls to curl or to Powershell's WebClient depending on the platform.
@jyn514 jyn514 added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Oct 15, 2020
@est31
Copy link
Member

est31 commented Oct 15, 2020

rustbuild doesn't have to depend on a http client library, it can just shell out to curl or WebClient as well. I think that's perfectly fine for anything for which http downloads are not the main purpose.

@Mark-Simulacrum
Copy link
Member

It looks like Python is already doing that -- interesting -- in that case it definitely seems fine to do so. It would be great if we could avoid duplicating the curl invocations but I wouldn't bend over backwards to do so.

@jyn514 jyn514 changed the title move LLVM setup logic from bootstrap.py to rustbuild move download-ci-llvm logic from bootstrap.py to rustbuild Oct 11, 2021
@jyn514
Copy link
Member

jyn514 commented Jun 27, 2022

Done in #95170.

@jyn514 jyn514 closed this as completed Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Mark-Simulacrum @est31 @alarsyo @jyn514