Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a lint for "extern mod extra;" in run-pass tests without "xfail-fast". #7416

Closed
bblum opened this issue Jun 26, 2013 · 3 comments
Closed

Add a lint for "extern mod extra;" in run-pass tests without "xfail-fast". #7416

bblum opened this issue Jun 26, 2013 · 3 comments
Labels
A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows

Comments

@bblum
Copy link
Contributor

bblum commented Jun 26, 2013

aaaaaaargh.
@alexcrichton
Copy link
Member

It would be awesome if we could not do the concatenate-all-tests thing on windows. That would allow us to test a lot more functionality to ensure things work on windows.

I presume that we concatenate everything because forking is slow on windows, so there may not be a way around the root problem. I agree though that for now a lint would be nice.

@huonw huonw mentioned this issue Jan 31, 2014
Closed
@huonw
Copy link
Member

huonw commented Jan 31, 2014

Triage: maybe we could resolve this with extern mod extra; etc. at the top of the crate that the combiner creates.

cc #8844 (check-fast metabug), and #6330 (similar thing, but for std::.. uses).

brson added a commit to brson/rust that referenced this issue Feb 25, 2014
@brson
Remove check-fast. Closes rust-lang#4193, rust-lang#8844, rust-lang#6330
b2bb2f5 
, rust-lang#7416
brson added a commit to brson/rust that referenced this issue Mar 22, 2014
@brson
Remove check-fast. Closes rust-lang#4193, rust-lang#8844, rust-lang#6330
769c4ea 
, rust-lang#7416
alexcrichton pushed a commit to alexcrichton/rust that referenced this issue Apr 5, 2014
@brson @alexcrichton
Remove check-fast. Closes rust-lang#4193, rust-lang#8844, rust-lang#6330
ae5da74 
, rust-lang#7416
alexcrichton pushed a commit to alexcrichton/rust that referenced this issue Apr 6, 2014
@brson @alexcrichton
Remove check-fast. Closes rust-lang#4193, rust-lang#8844, rust-lang#6330
072a920 
, rust-lang#7416
@alexcrichton
Copy link
Member

Closing, #13288 removed check-fast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @huonw @bblum