Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for peekable_next_if #72480

Closed
1 of 3 tasks
jyn514 opened this issue May 22, 2020 · 2 comments · Fixed by #80011
Closed
1 of 3 tasks

Tracking Issue for peekable_next_if #72480

jyn514 opened this issue May 22, 2020 · 2 comments · Fixed by #80011
Labels
A-iterators Area: Iterators B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC Libs-Small Libs issues that are considered "small" or self-contained Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@jyn514
Copy link
Member

jyn514 commented May 22, 2020

This is a tracking issue for the feature peekable_next_if (#72310).
The feature gate for the issue is #![feature(peekable_next_if)].

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also uses as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved Questions

  • Should next_if be named consume_if or eat_if?
  • Should next_if_eq be named consume or eat?
@jyn514 jyn514 added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label May 22, 2020
@jyn514
Copy link
Member Author

jyn514 commented May 22, 2020

@rustbot modify labels: T-libs

@jonas-schievink jonas-schievink added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. A-iterators Area: Iterators B-unstable Blocker: Implemented in the nightly compiler and unstable. labels May 22, 2020
@KodrAus KodrAus added Libs-Small Libs issues that are considered "small" or self-contained Libs-Tracked Libs issues that are tracked on the team's project board. labels Jul 29, 2020
@Stupremee
Copy link
Member

I don't think the methods should be renamed to something else, becuase Iterator also has a next method, and Peekable
should use the same name but with the if component.

Also, if these questions are resolved and there are no other blockers, I would like to go ahead and stabilize this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-iterators Area: Iterators B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC Libs-Small Libs issues that are considered "small" or self-contained Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants