Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Kind #64352

Closed
varkor opened this issue Sep 10, 2019 · 2 comments · Fixed by #64515
Closed

Rename Kind #64352

varkor opened this issue Sep 10, 2019 · 2 comments · Fixed by #64515
Assignees
@varkor
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. I-needs-decision Issue: In need of a decision. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@varkor
Copy link
Member

varkor commented Sep 10, 2019

A Kind is not really a kind: it's a term (e.g. a particular type, a particular lifetime or a particular value). However, "Term" is overloaded as terms are usually values of particular types (which is just one case here). KindedTerm has been suggested.
@varkor varkor added C-cleanup Category: PRs that clean code up or issues documenting cleanup. I-needs-decision Issue: In need of a decision. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 10, 2019
@varkor varkor self-assigned this Sep 10, 2019
@varkor varkor mentioned this issue Sep 16, 2019
Merged
@oli-obk
Copy link
Contributor

oli-obk commented Sep 22, 2019

For me, this doesn't clarify anthing. It just means I'm gonna learn another name that means nothing.

I liked the GenericArg suggestion, since it matches the AST/HIR naming for the equivalent values.

@varkor
Copy link
Member Author

varkor commented Sep 25, 2019 •
edited
Loading

I liked the GenericArg suggestion, since it matches the AST/HIR naming for the equivalent values.

That could work 👍

@bors bors closed this as completed in ddf4386 Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@varkor varkor

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. I-needs-decision Issue: In need of a decision. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename subst::Kind to subst::GenericArg varkor/rust
2 participants
@oli-obk @varkor