[1.38] Regression: expected module, found unresolved item crate::mod

[petrochenkov]

#63628 (comment)

expected module, found unresolved item crate::mod

./gh/xi-frontend/xi-term/beta-2019-08-13.txt:[INFO] [stderr] error[E0577]: expected module, found unresolved item `crate::mod`

This is the most hilarious case so far.
Apparently due to some recovery going wrong paths like {crate,self,super}::r#keyword silently resolve to Res::Err without reporting any error (I've made an issue for this - #63882).

Code in xrl-0.0.7 looked like this

pub(in crate::r#mod) fn new() { ... }

and it broke when visibility resolution switched to a different algorithm ("early resolution") in #63400, which doesn't have this bug.
I'd expect this issue to be discoverable by some kind of fuzzing, but I'd never expect it to be encountered by real code!

So, the regression is a bugfix and this bug needs to be fixed in other contexts as well, #63882 is the tracking issue for that.

[nikomatsakis]

check-in from compiler triage: this is the result of a bug-fix and is considered expected breakage. Closing.