Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run automatically UI tests when opening a PR changing rustdoc/CSS/JS content #60033

Closed
GuillaumeGomez opened this issue Apr 17, 2019 · 2 comments
Closed

Run automatically UI tests when opening a PR changing rustdoc/CSS/JS content #60033

GuillaumeGomez opened this issue Apr 17, 2019 · 2 comments
Assignees
@GuillaumeGomez
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

I think the change will need to take place in https://github.com/rust-lang/highfive to make things smoother.

cc @QuietMisdreavus
@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Apr 17, 2019
@GuillaumeGomez GuillaumeGomez self-assigned this Apr 17, 2019
@GuillaumeGomez GuillaumeGomez mentioned this issue Apr 20, 2019
Merged
@GuillaumeGomez GuillaumeGomez mentioned this issue Nov 7, 2019
Closed
5 tasks
@JohnTitor JohnTitor added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label May 30, 2020
@JohnTitor
Copy link
Member

JohnTitor commented May 30, 2020 •
edited
Loading

@GuillaumeGomez So, IIUC we expect it's done by this config, right?
https://github.com/rust-lang/highfive/blob/4966ceffefe8eba2756c84e7dc17d5cca9fa431f/highfive/configs/rust-lang/rust.json#L53

But I'm unsure if that config runs ui tests nowadays. And it seems our highfive fails to add the label when opened PRs that touch rustdoc related things, I doubt this is the cause.
Also, this is a nit point but the mention should be @rust-highfive, not @highfive imo.

@GuillaumeGomez
Copy link
Member Author

It's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuillaumeGomez @JohnTitor