Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop emitting DW_AT_linkage_name for non-mangled symbols #59422

Closed
rocallahan opened this issue Mar 25, 2019 · 1 comment · Fixed by #72620
Closed

Stop emitting DW_AT_linkage_name for non-mangled symbols #59422

rocallahan opened this issue Mar 25, 2019 · 1 comment · Fixed by #72620
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rocallahan
Copy link

Debuggers will try to demangle DW_AT_linkage_name names. However, rustc (1.33) is emitting non-mangled names in DW_AT_linkage_name attributes for #[no_mangle] symbols. I think you can just omit DW_AT_linkage_name completely for these symbols, which will also save a tiny bit of space.
@estebank estebank added the A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) label Mar 25, 2019
@jonas-schievink jonas-schievink added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 25, 2019
@tromey
Copy link
Contributor

tromey commented May 26, 2020

This is a dup of #46487

@tmiasko tmiasko mentioned this issue May 26, 2020
Merged
@bors bors closed this as completed in 14dc103 Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Omit DW_AT_linkage_name when it is the same as DW_AT_name tmiasko/rust
4 participants
@rocallahan @tromey @estebank @jonas-schievink