Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename-dependency doesn't perform hyphen/underscore translation #51795

Closed
kazcw opened this issue Jun 25, 2018 · 2 comments
Closed

rename-dependency doesn't perform hyphen/underscore translation #51795

kazcw opened this issue Jun 25, 2018 · 2 comments

Comments

@kazcw
Copy link

kazcw commented Jun 25, 2018

When renaming a dependency in Cargo.toml (rust-lang/cargo#5422),

This works: not_a = { path = "../a", package = "a" }
This doesn't: not-a = { path = "../a", package = "a" }; attempting to import the crate results in can't find crate for not_a

It's never necessary to use hyphens in a rename, but supporting it would be less surprising.

@ehuss
Copy link
Contributor

ehuss commented Oct 15, 2018

This should be fixed in the latest nightly (fixed via rust-lang/cargo#6140).

@dwijnand
Copy link
Member

I can confirm this is fixed, tested using the 2018-11-09 nightly I have installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants