Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed lints in 1.27 beta #51501

Closed
pietroalbini opened this issue Jun 11, 2018 · 6 comments
Closed

Renamed lints in 1.27 beta #51501

pietroalbini opened this issue Jun 11, 2018 · 6 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta.
Milestone

Comments

@pietroalbini
Copy link
Member

pietroalbini commented Jun 11, 2018

Please note it's unlikely this change will be reverted before the release.
This issue exists mostly to notify crate authors about the change.

In the next release of Rust, 1.27.0, a few lints will be renamed to be consistent with the other names and RFC 344. You can find the full rationale for the change and the list of changed lints in PR #50879.

Your crates have #[deny(warnings)] in the build, so the change broke their build. If you want to allow the lint while still supporting old compilers you can use:

#![allow(unknown_lints, renamed_and_removed_lints, old_lint, new_lint)]
@pietroalbini pietroalbini added the regression-from-stable-to-beta Performance or correctness regression from stable to beta. label Jun 11, 2018
@pietroalbini pietroalbini added this to the 1.27 milestone Jun 11, 2018
@petrochenkov
Copy link
Contributor

The root reason for all the regressions is actually error-chain, so everything will be fixed if rust-lang-deprecated/error-chain#247 is merged and minor version of error-chain is released.

Does anybody know who currently has rights in that repo? @Yamakaky and @brson seem to be unavailable.

@est31
Copy link
Member

est31 commented Jun 12, 2018

Does anybody know who currently has rights in that repo? @Yamakaky and @brson seem to be unavailable.

What matters far more than git access is who has crates.io access which according to the crates.io page is @alexcrichton @Yamakaky and @brson . Not sure how alex can be reached before the 1.27 release is out.

@Dylan-DPC-zz
Copy link

Not sure how alex can be reached before the 1.27 release is out.

This is why we created the Rust Bus Organisation. In such emergency cases, we can push releases on the owner's behalf.

@KodrAus
Copy link
Contributor

KodrAus commented Jun 12, 2018

In my opinion, this is the kind of thing that can happen with #[deny(warnings)], and while fixing it would be nice in the meantime there's also the solution of not denying warnings. I don't think it's worth bothering Alex over.

@Yamakaky
Copy link
Contributor

To be honest, I'm not really programming in rust these time (following the news though),so I kinda left error-chain behind. failure being there, I'm not sure it's worth it to maintain error-chain.

@pietroalbini
Copy link
Member Author

@Yamakaky 1.27 release is next week, if you have time to cut out a new error-chain release it would be awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta.
Projects
None yet
Development

No branches or pull requests

6 participants