Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core::slice::SliceExt removed in 1.27 beta #50834

Closed
pietroalbini opened this issue May 17, 2018 · 3 comments
Closed

core::slice::SliceExt removed in 1.27 beta #50834

pietroalbini opened this issue May 17, 2018 · 3 comments
Labels
C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Milestone

Comments

@pietroalbini
Copy link
Member

The core::slice::SliceExt trait was removed from the libcore public API in 1.27 beta, but it contained some stable methods in it, and it was possible to call them on stable. Its removal is breaking some crates.

Playground example

The cause is probably #49896, cc @SimonSapin @alexcrichton

@pietroalbini pietroalbini added I-nominated T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. C-bug Category: This is a bug. labels May 17, 2018
@pietroalbini pietroalbini added this to the 1.27 milestone May 17, 2018
@kennytm
Copy link
Member

kennytm commented May 17, 2018

This is expected: TooManyBees/super-metroid#1

@SimonSapin
Copy link
Contributor

As @kennytm said this particular build failure did come up in a pre-landing Crater run but was the only one that seemed "legit", and I submitted PR to make the code compile both before and after the change.

@pietroalbini
Copy link
Member Author

Sure. Marking this as "won't fix" then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants