Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtest: utilize jobserver #48532

Open
ishitatsuyuki opened this issue Feb 25, 2018 · 1 comment
Open

libtest: utilize jobserver #48532

ishitatsuyuki opened this issue Feb 25, 2018 · 1 comment
Labels
A-libtest Area: `#[test]` / the `test` library C-feature-request Category: A feature request, i.e: not implemented / a PR. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@ishitatsuyuki
Copy link
Contributor

Tests are normally CPU consuming tasks, and we can transparently utilize jobserver to achieve efficient core utilization.

Some usecases I can think of:

  • Tests which may spawn threads (including rustc codegen-units, but not limited to)
  • Using a parent make somewhere
@estebank estebank added the A-libtest Area: `#[test]` / the `test` library label Feb 25, 2018
@XAMPPRocky XAMPPRocky added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 14, 2018
@Mark-Simulacrum Mark-Simulacrum added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 3, 2018
@jonas-schievink jonas-schievink added C-feature-request Category: A feature request, i.e: not implemented / a PR. and removed C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Apr 20, 2020
@gilescope
Copy link
Contributor

Not having this was the reason why Alex said that parallel test running PRs could not be accepted into cargo, so this would unblock parallel testing across multiple crates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-libtest Area: `#[test]` / the `test` library C-feature-request Category: A feature request, i.e: not implemented / a PR. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
Status: No status
Development

No branches or pull requests

6 participants