Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom error handling from rustdoc #4698

Closed
brson opened this issue Jan 31, 2013 · 0 comments
Closed

Remove custom error handling from rustdoc #4698

brson opened this issue Jan 31, 2013 · 0 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@brson
Copy link
Contributor

brson commented Jan 31, 2013

In astsrv.rs rustdoc creates a custom diagnostic emitter for use with the compiler. It did this so that it could run resolve while ignoring errors, but it no longer runs resolve, so this code isn't doing anything.
brson added a commit that referenced this issue Jan 31, 2013
@brson
rustdoc: Stop using a custom error handler. Closes #4698
16ea4b0
@brson brson closed this as completed Jan 31, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Aug 28, 2020
@bors
Auto merge of rust-lang#5912 - ebroto:needless_doctest_main_improveme…
f8db258 
…nts, r=Manishearth,flip1995

Parse doctests in needless_doctest_main

This switches from text-based search to running the parser to avoid false positives. Inspired by how [rustdoc](https://github.com/rust-lang/rust/blob/3f3250500fe152b5759c21453ba9a9129808d0d8/src/librustdoc/test.rs#L366) handles this and by rust-lang#4729.

cc @llogiq

changelog: Fix multiple false positives in [`needless_doctest_main`].

Fixes rust-lang#5879
Fixes rust-lang#4906
Fixes rust-lang#5103
Fixes rust-lang#4698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brson