Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl priv methods are not private #4629

Closed
cpeterso opened this issue Jan 25, 2013 · 2 comments
Closed

impl priv methods are not private #4629

cpeterso opened this issue Jan 25, 2013 · 2 comments
Labels
A-trait-system Area: Trait system
Milestone

Comments

@cpeterso
Copy link
Contributor

priv fn in an impl does not create a private method. The following code compiles and runs without error, even though shl_unit() is marked priv: https://github.com/mozilla/rust/blob/e447521c1ca2dbead5b485ddc43060b282840817/src/libstd/bigint.rs#L452

extern mod std;
fn main() {
    std::bigint::BigUint::from_uint(2).shl_unit(3);
}

This issue might be related to issue #3452.

@catamorphism
Copy link
Contributor

Bumping to 0.7

@thestinger
Copy link
Contributor

@pcwalton fixed this

foo.rs:3:4: 3:51 error: method `shl_unit` is private
foo.rs:3     std::bigint::BigUint::from_uint(2).shl_unit(3);
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
error: aborting due to previous error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-trait-system Area: Trait system
Projects
None yet
Development

No branches or pull requests

3 participants