Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLVM_VERSION_MINOR is 0 in LLVM trunk now #36295

Closed
sanxiyn opened this issue Sep 6, 2016 · 3 comments
Closed

LLVM_VERSION_MINOR is 0 in LLVM trunk now #36295

sanxiyn opened this issue Sep 6, 2016 · 3 comments
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.

Comments

@sanxiyn
Copy link
Member

sanxiyn commented Sep 6, 2016

rustllvm includes some #if LLVM_VERSION_MINOR >= 8 checks which are intended as "LLVM 3.8 or later". Now LLVM SVN trunk is 4.0, LLVM_VERSION_MINOR is 0, and the check fails.

@sanxiyn sanxiyn added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Sep 6, 2016
@brson brson added the I-wrong label Sep 7, 2016
@shepmaster
Copy link
Member

Oh, are you also working on supporting LLVM 4.x? We are doing it for the AVR fork.

@shepmaster
Copy link
Member

Note that even with the version checks updated, the new LLVM code still fails (perhaps as should be expected). We've got some in-progress work and are tracking some of the work. I'd expect us to submit the non-AVR specific changes upstream, once they are working.

@sanxiyn
Copy link
Member Author

sanxiyn commented Sep 28, 2016

Fixed by #36742.

@sanxiyn sanxiyn closed this as completed Sep 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
Projects
None yet
Development

No branches or pull requests

3 participants