Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0106 needs to be updated to new format #35245

Closed
sophiajt opened this issue Aug 3, 2016 · 5 comments · Fixed by #35356
Closed

E0106 needs to be updated to new format #35245

sophiajt opened this issue Aug 3, 2016 · 5 comments · Fixed by #35356
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 3, 2016

From: src/test/compile-fail/E0106.rs

Error E0106 needs a span_label, updating it from:

error[E0106]: missing lifetime specifier
  --> src/test/compile-fail/E0106.rs:12:8
   |
12 |     x: &bool, //~ ERROR E0106
   |        ^^^^^

To:

error[E0106]: missing lifetime specifier
  --> src/test/compile-fail/E0106.rs:12:8
   |
12 |     x: &bool, //~ ERROR E0106
   |        ^^^^^ expected lifetime information
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 3, 2016
@Tiwalun
Copy link
Contributor

Tiwalun commented Aug 3, 2016

I'll try this one.

@arielb1
Copy link
Contributor

arielb1 commented Aug 3, 2016

I think "expected lifetime parameter" is a better label. bonus: have the label on the ampersand only.

@sophiajt
Copy link
Contributor Author

sophiajt commented Aug 3, 2016

👍 to @arielb1's suggestions

@Tiwalun
Copy link
Contributor

Tiwalun commented Aug 4, 2016

@arielb1 Do you mean like this?

error[E0106]: missing lifetime specifier
  --> src/test/compile-fail/E0106.rs:12:8
   |
12 |     x: &bool, //~ ERROR E0106
   |        ^^^^^
   |        |
   |        expected lifetime parameter

Or like this, with the primary span changed?

error[E0106]: missing lifetime specifier
  --> src/test/compile-fail/E0106.rs:12:8
   |
12 |     x: &bool, //~ ERROR E0106
   |        ^ expected lifetime parameter

@sophiajt
Copy link
Contributor Author

sophiajt commented Aug 4, 2016

I think he means the second one:

error[E0106]: missing lifetime specifier
  --> src/test/compile-fail/E0106.rs:12:8
   |
12 |     x: &bool, //~ ERROR E0106
   |        ^ expected lifetime parameter

sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 5, 2016
…andturner

Update E0106 error message to new format.

This fixes rust-lang#35245, as part of the big error message update in rust-lang#35233

r? @jonathandturner
eddyb added a commit to eddyb/rust that referenced this issue Aug 6, 2016
…andturner

Update E0106 error message to new format.

This fixes rust-lang#35245, as part of the big error message update in rust-lang#35233

r? @jonathandturner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants