Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support per-stage RUSTFLAGS in rustbuild. #33609

Closed
eddyb opened this issue May 13, 2016 · 5 comments · Fixed by #63722
Closed

Support per-stage RUSTFLAGS in rustbuild. #33609

eddyb opened this issue May 13, 2016 · 5 comments · Fixed by #63722
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@eddyb
Copy link
Member

eddyb commented May 13, 2016

Right now rustbuild invokes cargo which wants to rebuild the world if it sees a different RUSTFLAGS value, while my workflow involves changing RUSTFLAGS just to test stage1+ with -Z orbit.

It would be nice to have passing --stage1-rustflags "-Z orbit" to the python script (or the environment variable `RUSTFLAGS1="-Z orbit") just work.

Currently the Makefiles have something similar but it doesn't actually work for compiletest, just rustc.
@alexcrichton alexcrichton added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label May 13, 2016
@apaprocki
Copy link

Did rustbuild ever get support for this? This appears to also be breaking chroot builds that need to pass per-stage sysroot values.

@Mark-Simulacrum
Copy link
Member

I'm going to unassign @alexcrichton from this; I think others should be able to implement this and as far as I know they don't have any particular concern with this specific bug.

@Mark-Simulacrum Mark-Simulacrum added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jul 25, 2017
@Mark-Simulacrum Mark-Simulacrum added C-feature-request Category: A feature request, i.e: not implemented / a PR. and removed C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Jul 25, 2017
@Mark-Simulacrum Mark-Simulacrum added this to the impl period milestone Sep 15, 2017
@aturon aturon removed this from the impl period milestone Sep 15, 2017
@Mark-Simulacrum
Copy link
Member

We support this via RUSTFLAG_STAGE_NOT_0 and RUSTFLAGS_STAGE_0 set in the environment today.

@eddyb
Copy link
Member Author

eddyb commented Aug 12, 2019

@Mark-Simulacrum I wonder if we should switch to RUSTFLAGS_BOOTSTRAP and RUSTFLAGS_NOT_BOOTSTRAP.

@Mark-Simulacrum
Copy link
Member

That would make sense, I'll reopen to track that.

@Mark-Simulacrum Mark-Simulacrum mentioned this issue Aug 19, 2019
Merged
@bors bors closed this as completed in af77aed Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't use stage naming in RUSTFLAGS environment variables Mark-Simulacrum/rust
5 participants
@alexcrichton @eddyb @aturon @apaprocki @Mark-Simulacrum