Compiler panic while compiling the clippy for loop test

[josephDunne]

I was updating clippy to deal with 5efdde0 5647586 and ab9b844 when I ran into this compiler panic during testing

› RUST_BACKTRACE=1 rustc -g tests/compile-fail/for_loop.rs -L /tmp --target=x86_64-apple-darwin -L /tmp/for_loop.stage3.compile-fail.libaux -C prefer-dynamic -o /tmp/for_loop.stage3 -L target/debug/ -L target/debug/deps
ERROR:rbml::reader: failed to find block with tag 37
error: internal compiler error: unexpected panic
note: the compiler unexpectedly panicked. this is a bug.
note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
thread 'rustc' panicked at 'explicit panic', ../src/librbml/lib.rs:437
stack backtrace:
   1:        0x1131d5bf8 - std::sys::backtrace::tracing::imp::write::h63529ecac330b5bc
   2:        0x1131e1fe5 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::h0e99487804ecdaa3
   3:        0x1131e1b22 - std::panicking::default_hook::h1f0a2403a716c4a6
   4:        0x1131a5456 - std::sys_common::unwind::begin_unwind_inner::heae36551373e36bd
   5:        0x1100d5854 - std::sys_common::unwind::begin_unwind::h422885d31fe250dc
   6:        0x1100d2ee4 - rbml::reader::get_doc::h45c276ee042f63b8
   7:        0x10f2fa6e8 - rustc_metadata::decoder::get_type::hbfb459c93e92cf52
   8:        0x10f343755 - rustc_metadata::csearch::_<impl rustc..middle..cstore..CrateStore<'tcx> for cstore..CStore>::item_type::hcef1de0d0ce1bee8
   9:        0x1160d9469 - clippy::enum_glob_use::EnumGlobUse::lint_item::h14b92906d9ea3ab1
  10:        0x115ff88a7 - _<enum_glob_use..EnumGlobUse as rustc..lint..LateLintPass>::check_mod::hcad27a9c383a286a
  11:        0x10f8ecc94 - _<lint..context..LateContext<'a, 'tcx> as rustc_front..intravisit..Visitor<'v>>::visit_mod::h35f520250c131c4b
  12:        0x10f90fc75 - rustc::lint::context::check_crate::he0b5cdbf9c8a64c9
  13:        0x10e95f41e - rustc_driver::driver::phase_3_run_analysis_passes::_$u7b$$u7b$closure$u7d$$u7d$::h1d5b5af335ae8126
  14:        0x10e959a55 - rustc::ty::context::TyCtxt::create_and_enter::h2656c85b5a638887
  15:        0x10e95644f - rustc_driver::driver::phase_3_run_analysis_passes::h432eb92c0e12df32
  16:        0x10e929577 - rustc_driver::driver::compile_input::hb8958b270f32a505
  17:        0x10e9171cf - rustc_driver::run_compiler::h146dabfc96bf3a5a
  18:        0x10e914672 - std::sys_common::unwind::try::try_fn::h847694ac14db1c2b
  19:        0x1131d325b - __rust_try
  20:        0x1131d31e3 - std::sys_common::unwind::inner_try::h790ed072af125c7c
  21:        0x10e914f09 - _<F as alloc..boxed..FnBox<A>>::call_box::h64418c3ccdc3072e
  22:        0x1131e0ef8 - std::sys::thread::Thread::new::thread_start::hdaf9c8e3f2f1c46e
  23:     0x7fff9114c99c - _pthread_body
  24:     0x7fff9114c919 - _pthread_start

[josephDunne]

nightly revision:

rustc 1.9.0-nightly (d5a91e6 2016-03-26)
cargo 0.10.0-nightly (25e1301 2016-03-25)

[mcarton]

   9:        0x1160d9469 - clippy::enum_glob_use::EnumGlobUse::lint_item::h14b92906d9ea3ab1
                           ^^^^^^

The error is likely to be clippy’s fault, not rustc.

[mcarton]

Actually, that function is the only function with non-trivial change in your PR.

[josephDunne]

ERROR:rbml::reader: failed to find block with tag 37

are you sure? #29116
I am not sure so jsut checking :-)

[mcarton]

If there is Clippy stuff in the middle of the backtrace, it’s Clippy’s fault. You’re probably not using some rustc function properly.

[josephDunne]

ok thanks for looking