Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICE on Unicode escape in byte string literal #23620

Closed
kmcallister opened this issue Mar 22, 2015 · 0 comments · Fixed by #23625
Closed

ICE on Unicode escape in byte string literal #23620

kmcallister opened this issue Mar 22, 2015 · 0 comments · Fixed by #23625
Labels
A-parser Area: The parsing of Rust source code to an AST I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️

Comments

@kmcallister
Copy link
Contributor 

fn main() {
    b"\u{a66e}";
}
thread 'rustc' panicked at 'lexer accepted invalid byte literal \u{a66e} step 3', /home/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libsyntax/parse/mod.rs:592
@kmcallister kmcallister added I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ A-parser Area: The parsing of Rust source code to an AST labels Mar 22, 2015
@fhahn fhahn mentioned this issue Mar 22, 2015
Merged
fhahn added a commit to fhahn/rust that referenced this issue Mar 26, 2015
@fhahn
Prevent ICEs when parsing invalid escapes, closes rust-lang#23620
d43aebc
fhahn added a commit to fhahn/rust that referenced this issue Mar 27, 2015
@fhahn
Prevent ICEs when parsing invalid escapes, closes rust-lang#23620
afaa3b6
Manishearth added a commit to Manishearth/rust that referenced this issue Mar 27, 2015
@Manishearth
Rollup merge of rust-lang#23625 - fhahn:issue-23620-ice-unicode-bytes…
e65c6e5 
…tring, r=alexcrichton

 closes rust-lang#23620

This PR patches the issue mentioned in rust-lang#23620, but there is also an ICE for invalid escape sequences in byte literals. This is due to the fact that the `scan_byte` function returns ` token::intern(\"??\") ` for invalid bytes, resulting in an ICE later on. Is there a reason for this behavior? Shouldn't `scan_byte` fail when it encounters an invalid byte?

And I noticed a small inconsistency in the documentation. According to the formal byte literal definition in http://doc.rust-lang.org/reference.html#byte-and-byte-string-literals , a byte string literal contains `string_body *`, but according to the text (and the behavior of the lexer) it should not accept unicode escape sequences. Hence it should be replaced by `byte_body *`. If this is valid, I can add this fix to this PR.
alexcrichton added a commit to alexcrichton/rust that referenced this issue Mar 27, 2015
@alexcrichton
rollup merge of rust-lang#23625: fhahn/issue-23620-ice-unicode-bytest…
b79fbe0 
…ring

closes rust-lang#23620

This PR patches the issue mentioned in rust-lang#23620, but there is also an ICE for invalid escape sequences in byte literals. This is due to the fact that the `scan_byte` function returns ` token::intern("??") ` for invalid bytes, resulting in an ICE later on. Is there a reason for this behavior? Shouldn't `scan_byte` fail when it encounters an invalid byte?

And I noticed a small inconsistency in the documentation. According to the formal byte literal definition in http://doc.rust-lang.org/reference.html#byte-and-byte-string-literals , a byte string literal contains `string_body *`, but according to the text (and the behavior of the lexer) it should not accept unicode escape sequences. Hence it should be replaced by `byte_body *`. If this is valid, I can add this fix to this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-parser Area: The parsing of Rust source code to an AST I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not accept unicode escape characters in byte strings or as byte fhahn/rust
1 participant
@kmcallister