Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not error for unknown attributes at stage0 #22964

Closed
Manishearth opened this issue Mar 2, 2015 · 6 comments
Closed

Do not error for unknown attributes at stage0 #22964

Manishearth opened this issue Mar 2, 2015 · 6 comments

Comments

@Manishearth
Copy link
Member

Makes PRs like #21824 painful

@Manishearth
Copy link
Member Author

(I can mentor this, btw, but please ask first, I might have finished it since this is something we need)

@Manishearth
Copy link
Member Author

The relevant code is here. The custom_attribute gate should be within a #[cfg(not(stage0))] block.

@Manishearth
Copy link
Member Author

This won't work. The correct fix is to use #![cfg_attr(stage0, feature(custom_attribute))] on every crate

@awlnx
Copy link
Contributor

awlnx commented Mar 4, 2015

any tests needed to be ran other than compilation?

@Manishearth
Copy link
Member Author

You can run make check-stage1-cfail check-stage1 rpass if you want. This is something that's really only going to be verified when a snapshot gets made.

An easy way to test this is to just add a #[foo] somewhere in the libstd, and check that it compiles at stage0 but fails at stage1

@Manishearth
Copy link
Member Author

This was fixed (#23056)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants