Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrays have no primitive page in rustdoc #22714

Closed
SimonSapin opened this issue Feb 23, 2015 · 3 comments
Closed

Arrays have no primitive page in rustdoc #22714

SimonSapin opened this issue Feb 23, 2015 · 3 comments

Comments

@SimonSapin
Copy link
Contributor

E.g. like http://doc.rust-lang.org/std/core/primitive.slice.html but for [T; N].

cc #15318, #15654, @steveklabnik

@steveklabnik
Copy link
Member

diff --git a/src/libcore/array.rs b/src/libcore/array.rs
index e8f6e31..fc80dcb 100644
--- a/src/libcore/array.rs
+++ b/src/libcore/array.rs
@@ -14,6 +14,8 @@

 #![unstable(feature = "core")] // not yet reviewed

+#![doc(primitive = "array")]
+
 use clone::Clone;
 use cmp::{PartialEq, Eq, PartialOrd, Ord, Ordering};
 use fmt;

did not actually add the correct page, so I'm not sure. @alexcrichton , I think you helped me with something similar, what should I do to make rustdoc happy here?

@tomjakubowski
Copy link
Contributor

My experience with @steveklabnik patch (which included some rustdoc changes, here) was that it created a page for the array primitive, but the page did not have any impls. It looks like clean::Type::FixedVector ([T; n]) impls are pushed into the primitive page for slice. You can actually see them here today: http://doc.rust-lang.org/core/primitive.slice.html

I'll have a patch ready soon that instead relocates them to the array primitive docs. Is that what we want?

@tomjakubowski
Copy link
Contributor

This was closed by #23633

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants