Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiletest output newlines are weird #133879

Closed
matthiaskrgr opened this issue Dec 4, 2024 · 4 comments · Fixed by #133892
Closed

compiletest output newlines are weird #133879

matthiaskrgr opened this issue Dec 4, 2024 · 4 comments · Fixed by #133892
Assignees
@clubby789 @jieyouxu
Labels
A-compiletest Area: The compiletest test runner C-bug Category: This is a bug. D-papercut Diagnostics: An error or lint that needs small tweaks. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@matthiaskrgr
Copy link
Member

acabb52

Image
@matthiaskrgr matthiaskrgr added A-compiletest Area: The compiletest test runner C-bug Category: This is a bug. D-papercut Diagnostics: An error or lint that needs small tweaks. labels Dec 4, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Dec 4, 2024
@matthiaskrgr
Copy link
Member Author

#133817 seems suspicious cc @clubby789 @jieyouxu

@fmease
Copy link
Member

fmease commented Dec 4, 2024 •
edited
Loading

Likely missed to replace print!(…)s with eprint!(…) (having replaced println!(…)s with eprintln!(…)).

@clubby789
Copy link
Contributor

Ah good point. Will make a followup

@clubby789 clubby789 self-assigned this Dec 5, 2024
@jieyouxu jieyouxu added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Dec 5, 2024
@jieyouxu jieyouxu mentioned this issue Dec 5, 2024
Merged
@jieyouxu
Copy link
Member

jieyouxu commented Dec 5, 2024

Revert PR: #133892

@jieyouxu jieyouxu self-assigned this Dec 5, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Dec 5, 2024
@rust-timer
Unrolled build for rust-lang#133892
f8d58a1 
Rollup merge of rust-lang#133892 - jieyouxu:revert-eprintln, r=jieyouxu

Revert rust-lang#133817

This reverts commit 0585134, reversing changes made to 5530869.

rust-lang#133817 unfortunately only converted the `println!` instances to `eprintln!`, meaning that some test output (via compiletest/bootstrap) was messed up because stdout/stderr output interleaved improperly when some `println!` instances were converted to `eprintln!` instances, while some `print!` instances remain unchanged. This made reading test output annoying for contributors cc rust-lang#133879.

Closes rust-lang#133879 by reverting.

rust-lang#133817 can be relanded in the future when `print!` instances are also matched with `println!` instances.

cc `@clubby789`

This is a clean revert so I'm going to self-approve this PR.
@bors bors closed this as completed in 1f1dfd5 Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clubby789 clubby789

@jieyouxu jieyouxu

Labels
A-compiletest Area: The compiletest test runner C-bug Category: This is a bug. D-papercut Diagnostics: An error or lint that needs small tweaks. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert #133817 jieyouxu/rust
5 participants
@matthiaskrgr @clubby789 @fmease @jieyouxu @rustbot