Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: the parameter type impl InferencePredicate may not live long enough #130577

Open
BoxyUwU opened this issue Sep 19, 2024 · 2 comments
Open
Labels
I-prioritize Issue: Indicates that prioritization has been requested for this issue. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-types Relevant to the types team, which will review and decide on the PR/issue.
Milestone

Comments

@BoxyUwU
Copy link
Member

BoxyUwU commented Sep 19, 2024

[INFO] [stdout] error[E0309]: the parameter type `impl InferencePredicate` may not live long enough
[INFO] [stdout]   --> src/inference/engine/mod.rs:82:9
[INFO] [stdout]    |
[INFO] [stdout] 66 |   pub trait TagDefinition<'cfg, _Bound = &'cfg Self>:
[INFO] [stdout]    |                           ---- the parameter type `impl InferencePredicate` must be valid for the lifetime `'cfg` as defined here...
[INFO] [stdout] ...
[INFO] [stdout] 82 | /         self.append(InferenceDefinitionPair {
[INFO] [stdout] 83 | |             pred,
[INFO] [stdout] 84 | |             value: TagFn(move |element: &mut Element<'cfg>| element.apply_tags(tags.clone())),
[INFO] [stdout] 85 | |             next: EmptyInferenceDefinition {},
[INFO] [stdout] 86 | |         })
[INFO] [stdout]    | |__________^ ...so that the type `impl InferencePredicate` will meet its required lifetime bounds

note: if the relevant team already accepted this breakage then the issue can be closed

@BoxyUwU BoxyUwU added I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-types Relevant to the types team, which will review and decide on the PR/issue. labels Sep 19, 2024
@rustbot rustbot added I-prioritize Issue: Indicates that prioritization has been requested for this issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Sep 19, 2024
@compiler-errors
Copy link
Member

This was a regression in #124336, which was not caught by the crater run.

@BoxyUwU BoxyUwU removed the I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ label Sep 19, 2024
@saethlin saethlin removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 19, 2024
@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Sep 24, 2024
@apiraino
Copy link
Contributor

apiraino commented Oct 7, 2024

#124336 is merged and IIUC regressions accepted, so this could be probably be closed around the new stable 1.82 release

@Mark-Simulacrum Mark-Simulacrum added this to the 1.82.0 milestone Oct 11, 2024
@Mark-Simulacrum Mark-Simulacrum added regression-from-stable-to-stable Performance or correctness regression from one stable version to another. and removed regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Nov 22, 2024
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-prioritize Issue: Indicates that prioritization has been requested for this issue. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-types Relevant to the types team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants