Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for release notes of #130334: Fix SDKROOT ignore on macOS #130335

Closed
3 tasks
rustbot opened this issue Sep 14, 2024 · 3 comments
Closed
3 tasks

Tracking issue for release notes of #130334: Fix SDKROOT ignore on macOS #130335

rustbot opened this issue Sep 14, 2024 · 3 comments
Labels
A-cross Area: Cross compilation O-macos Operating system: macOS relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone

Comments

@rustbot
Copy link
Collaborator

rustbot commented Sep 14, 2024

This issue tracks the release notes text for #130334.

Steps

  • Proposed text is drafted by PR author (or team) making the noteworthy change.
  • Issue is nominated for release team review of clarity for wider audience.
  • Release team includes text in release notes/blog posts.

Release notes text

The responsible team for the underlying change should edit this section to replace the automatically generated link with a succinct description of what changed, drawing upon text proposed by the author (either in discussion or through direct editing).

# Compatibility notes
- [Fix `SDKROOT` ignore on macOS #130334](https://github.com/rust-lang/rust/pull/130334)

Tip

Use the previous releases categories to help choose which one(s) to use.
The category will be de-duplicated with all the other ones by the release team.

More than one section can be included if needed.

Release blog section

If the change is notable enough for inclusion in the blog post, the responsible team should add content to this section.
Otherwise leave it empty.

cc @madsmtm, @jieyouxu -- origin issue/PR authors and assignees for starting to draft text

@rustbot rustbot added A-cross Area: Cross compilation O-macos Operating system: macOS relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Sep 14, 2024
@jieyouxu
Copy link
Member

@madsmtm please feel free to suggest any better wording of the compat notes.

@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 14, 2024
@jieyouxu
Copy link
Member

Note that #130334 (comment)

We might not want to do that before it's also fixed when linking with the default linker.

So it's unclear if we want relnotes for this specifically.

@rustbot rustbot added this to the 1.83.0 milestone Sep 14, 2024
@cuviper
Copy link
Member

cuviper commented Nov 22, 2024

I'm gonna say no, let's not mention it yet.

@cuviper cuviper closed this as completed Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cross Area: Cross compilation O-macos Operating system: macOS relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants